public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
* [gentoo-dev] [PATCH] go-module.eclass: drop --mod=readonly from GOFLAGS
@ 2021-08-29  1:12 William Hubbs
  2021-09-01 16:08 ` William Hubbs
  0 siblings, 1 reply; 2+ messages in thread
From: William Hubbs @ 2021-08-29  1:12 UTC (permalink / raw
  To: gentoo-dev; +Cc: robbat2, William Hubbs

As of go 1.16, --mod=readonly is the default, so we don't need to
specify it.
https://golang.org/ref/mod#build-commands
https://golang.org/doc/go1.16

Signed-off-by: William Hubbs <williamh@gentoo.org>
---
 eclass/go-module.eclass | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/eclass/go-module.eclass b/eclass/go-module.eclass
index 053861a1a18..d51b8279f97 100644
--- a/eclass/go-module.eclass
+++ b/eclass/go-module.eclass
@@ -75,9 +75,7 @@ export GOCACHE="${T}/go-build"
 # The following go flags should be used for all builds.
 # -v prints the names of packages as they are compiled
 # -x prints commands as they are executed
-# -mod=readonly do not update go.mod/go.sum but fail if updates are needed
-# -mod=vendor use the vendor directory instead of downloading dependencies
-export GOFLAGS="-v -x -mod=readonly"
+export GOFLAGS="-v -x"
 
 # Do not complain about CFLAGS etc since go projects do not use them.
 QA_FLAGS_IGNORED='.*'
-- 
2.31.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [gentoo-dev] [PATCH] go-module.eclass: drop --mod=readonly from GOFLAGS
  2021-08-29  1:12 [gentoo-dev] [PATCH] go-module.eclass: drop --mod=readonly from GOFLAGS William Hubbs
@ 2021-09-01 16:08 ` William Hubbs
  0 siblings, 0 replies; 2+ messages in thread
From: William Hubbs @ 2021-09-01 16:08 UTC (permalink / raw
  To: gentoo-dev

[-- Attachment #1: Type: text/plain, Size: 425 bytes --]

On Sat, Aug 28, 2021 at 08:12:53PM -0500, William Hubbs wrote:
> As of go 1.16, --mod=readonly is the default, so we don't need to
> specify it.
> https://golang.org/ref/mod#build-commands
> https://golang.org/doc/go1.16
> 
> Signed-off-by: William Hubbs <williamh@gentoo.org>
> ---
>  eclass/go-module.eclass | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)

This is in the tree.

Thanks,

William

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-09-01 16:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-08-29  1:12 [gentoo-dev] [PATCH] go-module.eclass: drop --mod=readonly from GOFLAGS William Hubbs
2021-09-01 16:08 ` William Hubbs

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox