Re: [gentoo-dev] [PATCH] xdg.eclass: add EAPI 8 support

[Ionen Wolkens <ionen@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 1453 bytes --]

It'd probably need more discussion but there's two things I'd like
to see if EAPI-8 bump this:

1. remove src_prepare export in EAPI-8
While "some" packages need xdg_environment_reset, most don't because
the eclass is often only inherited to handle icons/.desktop and this
just needlessly overwrite the src_prepare of other eclasses requiring
more careful inherit ordering (e.g. inherit xdg cmake).

I'd prefer it was clear when a package need this by calling
xdg_environment_reset directly. Unless there is a non-trivial amount
of packages that need it (e.g. for tests) that I'm not aware of.

2. no *DEPEND in EAPI-8 rather than IDEPEND
xdg-utils is designed to not fail if these tools are missing and
cache updates are done "all at once" catching anything missing.
Then this cache shouldn't be needed until these tools are emerged,
preferably as a dep of a library using this cache + do 1st generation.

Many ebuilds already lack these deps by using xdg-utils directly,
so impact should be minimal.

Lack of *DEPEND is also useful for packages with optional gui support
that don't always install icons/.desktop, without falling back to
xdg-utils.

Old DEPEND should be kept as-is not to risk breaking packages with odd
checks that need it present at build time. I'd rather no RDEPEND switch
either as it'll just complicate things with revbumps and tools don't
really need to be in RDEPEND given the above.

-- 
ionen

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]