public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
* [gentoo-dev] USE=pic reminder
@ 2005-04-15 14:07 Mike Frysinger
  2005-04-15 14:13 ` Diego 'Flameeyes' Pettenò
                   ` (3 more replies)
  0 siblings, 4 replies; 16+ messages in thread
From: Mike Frysinger @ 2005-04-15 14:07 UTC (permalink / raw
  To: gentoo-dev

as a reminder, NEVER utilize USE=pic in your package unless you know exactly 
what it's for and you're sure you need it ... a quick `grep -Rl ^IUSE=.*pic` 
of the tree shows a bunch of ebuilds which appear to be misusing it:
app-admin/amanda
app-text/djvu
media-libs/guilib
media-libs/libvisual
media-tv/tvtime
media-video/avidemux
net-im/silc-plugin

packages which just straight up suck at life wrt PIC handling:
net-mail/uw-imap
net-mail/checkpassword
(anyone who just has 'append-flags -fPIC' because it 'worked')

fix your packages people or i'll fix you !

to prevent this in the future, perhaps i'll move USE=pic into use.local.desc 
so that people stop thinking it's OK to use normally ... or maybe i'll revise 
the description with 'dont touch this flag unless you know what you are 
doing' ... thoughts ?
-mike
--
gentoo-dev@gentoo.org mailing list


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [gentoo-dev] USE=pic reminder
  2005-04-15 14:07 [gentoo-dev] USE=pic reminder Mike Frysinger
@ 2005-04-15 14:13 ` Diego 'Flameeyes' Pettenò
  2005-04-15 14:23   ` Mike Frysinger
  2005-04-15 14:29 ` Francesco Riosa
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 16+ messages in thread
From: Diego 'Flameeyes' Pettenò @ 2005-04-15 14:13 UTC (permalink / raw
  To: gentoo-dev

[-- Attachment #1: Type: text/plain, Size: 296 bytes --]

On Friday 15 April 2005 16:07, Mike Frysinger wrote:
> media-video/avidemux
This is already removed by patch on bug #89097.. I anyway think that this is 
my fault (as for djvu and tvtime, probably).
Sorry about that.

-- 
Diego "Flameeyes" Pettenò
http://wwwstud.dsi.unive.it/~dpetteno/

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [gentoo-dev] USE=pic reminder
  2005-04-15 14:13 ` Diego 'Flameeyes' Pettenò
@ 2005-04-15 14:23   ` Mike Frysinger
  2005-04-15 14:33     ` Diego 'Flameeyes' Pettenò
  2005-04-15 14:35     ` Jason Stubbs
  0 siblings, 2 replies; 16+ messages in thread
From: Mike Frysinger @ 2005-04-15 14:23 UTC (permalink / raw
  To: gentoo-dev

On Friday 15 April 2005 10:13 am, Diego 'Flameeyes' Pettenò wrote:
> On Friday 15 April 2005 16:07, Mike Frysinger wrote:
> > media-video/avidemux
>
> This is already removed by patch on bug #89097.. I anyway think that this
> is my fault (as for djvu and tvtime, probably).
> Sorry about that.

you have an execuse ... you havent taken the dev quiz yet which has a PIC 
usage question ;)
-mike

--
gentoo-dev@gentoo.org mailing list


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [gentoo-dev] USE=pic reminder
  2005-04-15 14:07 [gentoo-dev] USE=pic reminder Mike Frysinger
  2005-04-15 14:13 ` Diego 'Flameeyes' Pettenò
@ 2005-04-15 14:29 ` Francesco Riosa
  2005-04-15 14:50   ` Simon Stelling
  2005-04-15 15:58   ` Mike Frysinger
  2005-04-15 14:55 ` Jan Brinkmann
  2005-04-18  6:47 ` Kevin F. Quinn
  3 siblings, 2 replies; 16+ messages in thread
From: Francesco Riosa @ 2005-04-15 14:29 UTC (permalink / raw
  To: gentoo-dev

Mike Frysinger wrote:

>as a reminder, NEVER utilize USE=pic in your package unless you know exactly 
>
[... snip of how much PIC is bad ]

A clarification: It's ok to use it _only_ for _libraryes_ by default ?
i.e
econf [...] --with-lib-ccflags="-fPIC"

Using it now and interested to know if it's plain wrong

--
gentoo-dev@gentoo.org mailing list


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [gentoo-dev] USE=pic reminder
  2005-04-15 14:23   ` Mike Frysinger
@ 2005-04-15 14:33     ` Diego 'Flameeyes' Pettenò
  2005-04-15 14:35     ` Jason Stubbs
  1 sibling, 0 replies; 16+ messages in thread
From: Diego 'Flameeyes' Pettenò @ 2005-04-15 14:33 UTC (permalink / raw
  To: gentoo-dev

[-- Attachment #1: Type: text/plain, Size: 301 bytes --]

On Friday 15 April 2005 16:23, Mike Frysinger wrote:
> you have an execuse ... you havent taken the dev quiz yet which has a PIC
> usage question ;)
Well actually now I taken it :) but the patches where previous to that :P

-- 
Diego "Flameeyes" Pettenò
http://wwwstud.dsi.unive.it/~dpetteno/

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [gentoo-dev] USE=pic reminder
  2005-04-15 14:23   ` Mike Frysinger
  2005-04-15 14:33     ` Diego 'Flameeyes' Pettenò
@ 2005-04-15 14:35     ` Jason Stubbs
  2005-04-15 18:43       ` Mike Frysinger
  1 sibling, 1 reply; 16+ messages in thread
From: Jason Stubbs @ 2005-04-15 14:35 UTC (permalink / raw
  To: gentoo-dev

On Friday 15 April 2005 23:23, Mike Frysinger wrote:
> On Friday 15 April 2005 10:13 am, Diego 'Flameeyes' Pettenò wrote:
> > On Friday 15 April 2005 16:07, Mike Frysinger wrote:
> > > media-video/avidemux
> >
> > This is already removed by patch on bug #89097.. I anyway think that this
> > is my fault (as for djvu and tvtime, probably).
> > Sorry about that.
>
> you have an execuse ... you havent taken the dev quiz yet which has a PIC
> usage question ;)

How can that be so? Was it removed? Is flameeyes incredible old and silent?

Regards,
Jason Stubbs

--
gentoo-dev@gentoo.org mailing list


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [gentoo-dev] USE=pic reminder
  2005-04-15 14:29 ` Francesco Riosa
@ 2005-04-15 14:50   ` Simon Stelling
  2005-04-15 15:58   ` Mike Frysinger
  1 sibling, 0 replies; 16+ messages in thread
From: Simon Stelling @ 2005-04-15 14:50 UTC (permalink / raw
  To: gentoo-dev

Hi,

Francesco Riosa wrote:
> A clarification: It's ok to use it _only_ for _libraryes_ by default ?
> i.e
> econf [...] --with-lib-ccflags="-fPIC"
> 
> Using it now and interested to know if it's plain wrong

Shared objects should be built with -fPIC anyway, since a few arches
require it and it makes sense.

Greetings,

blubb
--
gentoo-dev@gentoo.org mailing list


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [gentoo-dev] USE=pic reminder
  2005-04-15 14:07 [gentoo-dev] USE=pic reminder Mike Frysinger
  2005-04-15 14:13 ` Diego 'Flameeyes' Pettenò
  2005-04-15 14:29 ` Francesco Riosa
@ 2005-04-15 14:55 ` Jan Brinkmann
  2005-04-18  6:47 ` Kevin F. Quinn
  3 siblings, 0 replies; 16+ messages in thread
From: Jan Brinkmann @ 2005-04-15 14:55 UTC (permalink / raw
  To: gentoo-dev

[-- Attachment #1: Type: text/plain, Size: 731 bytes --]

On Fri, Apr 15, 2005 at 10:07:53AM -0400, Mike Frysinger wrote:
> as a reminder, NEVER utilize USE=pic in your package unless you know exactly 
> what it's for and you're sure you need it ... a quick `grep -Rl ^IUSE=.*pic` 
> of the tree shows a bunch of ebuilds which appear to be misusing it:
> app-admin/amanda
> app-text/djvu
> media-libs/guilib
> media-libs/libvisual
> media-tv/tvtime
> media-video/avidemux
> net-im/silc-plugin
> 

fixed for:
- media-libs/guilib
- media-libs/libvisual
- media-video/avidemux

-- 
Jan Brinkmann :	Gentoo Developer (Amd64, Java, PPC, Sound, Video)
Email:		luckyduck (at) gentoo.org
Web: 		http://the-luckyduck.de
GPG:		gpg --keyserver pgp.mit.edu --recv-key 0xE38C3BBF

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [gentoo-dev] USE=pic reminder
  2005-04-15 14:29 ` Francesco Riosa
  2005-04-15 14:50   ` Simon Stelling
@ 2005-04-15 15:58   ` Mike Frysinger
  2005-04-15 17:30     ` Francesco Riosa
  1 sibling, 1 reply; 16+ messages in thread
From: Mike Frysinger @ 2005-04-15 15:58 UTC (permalink / raw
  To: gentoo-dev

On Friday 15 April 2005 10:29 am, Francesco Riosa wrote:
> Mike Frysinger wrote:
> >as a reminder, NEVER utilize USE=pic in your package unless you know
> > exactly
>
> [... snip of how much PIC is bad ]

PIC isnt bad ... people misusing USE=pic is bad

> A clarification: It's ok to use it _only_ for _libraryes_ by default ?

a good rule of thumb:
shared objects should always be built with PIC

> i.e
> econf [...] --with-lib-ccflags="-fPIC"

ive never seen/used --with-lib-ccflags configure option before, but i imagine 
it'll affect static libraries too right ?  you dont want that

the large majority of autotooled package gets PIC handling right so you 
shouldnt need this kind of crap ...
-mike
--
gentoo-dev@gentoo.org mailing list


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [gentoo-dev] USE=pic reminder
  2005-04-15 15:58   ` Mike Frysinger
@ 2005-04-15 17:30     ` Francesco Riosa
  0 siblings, 0 replies; 16+ messages in thread
From: Francesco Riosa @ 2005-04-15 17:30 UTC (permalink / raw
  To: gentoo-dev

Mike Frysinger wrote:

>On Friday 15 April 2005 10:29 am, Francesco Riosa wrote:
>  
>
>>Mike Frysinger wrote:
>>    
>>
>>>as a reminder, NEVER utilize USE=pic in your package unless you know
>>>exactly
>>>      
>>>
>>[... snip of how much PIC is bad ]
>>    
>>
>
>PIC isnt bad ... people misusing USE=pic is bad
>  
>
received.

>  
>
>>A clarification: It's ok to use it _only_ for _libraryes_ by default ?
>>    
>>
>
>a good rule of thumb:
>shared objects should always be built with PIC
>
>  
>
>>i.e
>>econf [...] --with-lib-ccflags="-fPIC"
>>    
>>
>
>ive never seen/used --with-lib-ccflags configure option before, but i imagine 
>it'll affect static libraries too right ?  you dont want that
>
>the large majority of autotooled package gets PIC handling right so you 
>shouldnt need this kind of crap ...
>-mike
>  
>
fast grepping on "configure" show code for -fPIC utilization --> I must
see how to change the ebuilds my worryes goes to amd64 ... will see

--
gentoo-dev@gentoo.org mailing list


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [gentoo-dev] USE=pic reminder
  2005-04-15 14:35     ` Jason Stubbs
@ 2005-04-15 18:43       ` Mike Frysinger
  2005-04-18 20:50         ` John Huttley
  0 siblings, 1 reply; 16+ messages in thread
From: Mike Frysinger @ 2005-04-15 18:43 UTC (permalink / raw
  To: gentoo-dev

On Friday 15 April 2005 10:35 am, Jason Stubbs wrote:
> On Friday 15 April 2005 23:23, Mike Frysinger wrote:
> > On Friday 15 April 2005 10:13 am, Diego 'Flameeyes' Pettenò wrote:
> > > On Friday 15 April 2005 16:07, Mike Frysinger wrote:
> > > > media-video/avidemux
> > >
> > > This is already removed by patch on bug #89097.. I anyway think that
> > > this is my fault (as for djvu and tvtime, probably).
> > > Sorry about that.
> >
> > you have an execuse ... you havent taken the dev quiz yet which has a PIC
> > usage question ;)
>
> How can that be so? Was it removed? Is flameeyes incredible old and silent?

as he said himself, he made the mistakes before he took the quiz
-mike

--
gentoo-dev@gentoo.org mailing list


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [gentoo-dev] USE=pic reminder
  2005-04-15 14:07 [gentoo-dev] USE=pic reminder Mike Frysinger
                   ` (2 preceding siblings ...)
  2005-04-15 14:55 ` Jan Brinkmann
@ 2005-04-18  6:47 ` Kevin F. Quinn
  3 siblings, 0 replies; 16+ messages in thread
From: Kevin F. Quinn @ 2005-04-18  6:47 UTC (permalink / raw
  To: gentoo-dev

Mike Frysinger wrote:

> as a reminder, NEVER utilize USE=pic in your package unless you know 
> exactly what it's for and you're sure you need it

I figured this use flag should be used to ensure libraries are built as PIC (i.e. conform to the relevant ABI).  This is a common problem on the media packages for example which often have non-PIC x86 assembler (sometimes these are bugs, other times it's deliberate to get every ounce of performance).  I've been mooting the use of 'use pic' to decide configure options and conditionally apply patches (where the latter would reduce performance).  This was my reading of the description in use.desc.  However it has been indicated to me recently that USE=pic shouldn't be used for this.

If the latter is correct, perhaps the description of the use flag could be improved.

On a related note, USE=pie could be clarified as well (relocated to use.local.desc against sys-lang/gcc perhaps).

As a general comment, I think clear use flag descriptions in *.desc are preferable to rules buried somewhere in the morass of developer documentation.
I searched briefly for policy rules on USE=pic but didn't find any.  "briefly" is the key word here; I'm not about to spend hours reading the aforementioned morass every time I want to know whether I'm using the right USE keyword or not; I expect to find clear answers in use*.desc.

Kev.



-- 
gentoo-dev@gentoo.org mailing list


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [gentoo-dev] USE=pic reminder
  2005-04-15 18:43       ` Mike Frysinger
@ 2005-04-18 20:50         ` John Huttley
  2005-04-18 21:04           ` Diego 'Flameeyes' Pettenò
  0 siblings, 1 reply; 16+ messages in thread
From: John Huttley @ 2005-04-18 20:50 UTC (permalink / raw
  To: gentoo-dev

[-- Attachment #1: Type: text/plain, Size: 358 bytes --]

Would someone please expand on this?
perhaps a link if its documented elseware?

I have been compiling everything recently with pic and pie.
I thought this would be a prerequisite for effective use of "prelink".

A minor hit in program speed would not concern me.

Regards,

John

-- 
John Huttley <john@mwk.co.nz <mailto:john@mwk.co.nz>>
MWK Computers Ltd


[-- Attachment #2: Type: text/html, Size: 649 bytes --]

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [gentoo-dev] USE=pic reminder
  2005-04-18 20:50         ` John Huttley
@ 2005-04-18 21:04           ` Diego 'Flameeyes' Pettenò
  2005-04-18 22:04             ` Mike Frysinger
  0 siblings, 1 reply; 16+ messages in thread
From: Diego 'Flameeyes' Pettenò @ 2005-04-18 21:04 UTC (permalink / raw
  To: gentoo-dev

[-- Attachment #1: Type: text/plain, Size: 447 bytes --]

On Monday 18 April 2005 22:50, John Huttley wrote:
> I have been compiling everything recently with pic and pie.
> I thought this would be a prerequisite for effective use of "prelink".
It's a prerequisite for prelinking shared libraries, afaik. It's not needed 
for executables, so this shouldn't be a problem.

-- 
Diego "Flameeyes" Pettenò
Gentoo Developer (Gentoo/FreeBSD, Video, Gentoo/AMD64)

http://dev.gentoo.org/~flameeyes/


[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [gentoo-dev] USE=pic reminder
  2005-04-18 21:04           ` Diego 'Flameeyes' Pettenò
@ 2005-04-18 22:04             ` Mike Frysinger
  2005-04-19 19:27               ` Paul de Vrieze
  0 siblings, 1 reply; 16+ messages in thread
From: Mike Frysinger @ 2005-04-18 22:04 UTC (permalink / raw
  To: gentoo-dev

On Monday 18 April 2005 05:04 pm, Diego 'Flameeyes' Pettenò wrote:
> On Monday 18 April 2005 22:50, John Huttley wrote:
> > I have been compiling everything recently with pic and pie.
> > I thought this would be a prerequisite for effective use of "prelink".
>
> It's a prerequisite for prelinking shared libraries, afaik.

correct

> It's not needed for executables, so this shouldn't be a problem.

executables are not shared objects so you do not build them with PIC (this of 
course does not cover hardened usage of PIC/PIE)
-mike

-- 
gentoo-dev@gentoo.org mailing list


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [gentoo-dev] USE=pic reminder
  2005-04-18 22:04             ` Mike Frysinger
@ 2005-04-19 19:27               ` Paul de Vrieze
  0 siblings, 0 replies; 16+ messages in thread
From: Paul de Vrieze @ 2005-04-19 19:27 UTC (permalink / raw
  To: gentoo-dev

[-- Attachment #1: Type: text/plain, Size: 688 bytes --]

On Tuesday 19 April 2005 00:04, Mike Frysinger wrote:
> On Monday 18 April 2005 05:04 pm, Diego 'Flameeyes' Pettenò wrote:
> > On Monday 18 April 2005 22:50, John Huttley wrote:
> > > I have been compiling everything recently with pic and pie.
> > > I thought this would be a prerequisite for effective use of "prelink".
> >
> > It's a prerequisite for prelinking shared libraries, afaik.
>
> correct

Even on x86 normal (non-prelinked) shared libraries should be built with 
-fPIC. They will however continue to function (albeight slower) when not 
built properly.

Paul

-- 
Paul de Vrieze
Gentoo Developer
Mail: pauldv@gentoo.org
Homepage: http://www.devrieze.net

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2005-04-19 19:27 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-04-15 14:07 [gentoo-dev] USE=pic reminder Mike Frysinger
2005-04-15 14:13 ` Diego 'Flameeyes' Pettenò
2005-04-15 14:23   ` Mike Frysinger
2005-04-15 14:33     ` Diego 'Flameeyes' Pettenò
2005-04-15 14:35     ` Jason Stubbs
2005-04-15 18:43       ` Mike Frysinger
2005-04-18 20:50         ` John Huttley
2005-04-18 21:04           ` Diego 'Flameeyes' Pettenò
2005-04-18 22:04             ` Mike Frysinger
2005-04-19 19:27               ` Paul de Vrieze
2005-04-15 14:29 ` Francesco Riosa
2005-04-15 14:50   ` Simon Stelling
2005-04-15 15:58   ` Mike Frysinger
2005-04-15 17:30     ` Francesco Riosa
2005-04-15 14:55 ` Jan Brinkmann
2005-04-18  6:47 ` Kevin F. Quinn

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox