From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([69.77.167.62] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1KcfM0-0007gi-JV for garchives@archives.gentoo.org; Mon, 08 Sep 2008 11:56:24 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id D59A5E02D2; Mon, 8 Sep 2008 11:56:23 +0000 (UTC) Received: from mailrelay.rz.uni-wuerzburg.de (wrzx28.rz.uni-wuerzburg.de [132.187.3.28]) by pigeon.gentoo.org (Postfix) with ESMTP id A9F5EE02D2 for ; Mon, 8 Sep 2008 11:56:23 +0000 (UTC) Received: from virusscan.mail (localhost [127.0.0.1]) by mailrelay.mail (Postfix) with ESMTP id 6097EA071B for ; Mon, 8 Sep 2008 13:56:22 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by virusscan.mail (Postfix) with ESMTP id 53D19A06F0 for ; Mon, 8 Sep 2008 13:56:22 +0200 (CEST) Received: from wmax001.mathematik.uni-wuerzburg.de (wmax001.mathematik.uni-wuerzburg.de [132.187.61.1]) by mailmaster.uni-wuerzburg.de (Postfix) with ESMTP id 402EEA070F for ; Mon, 8 Sep 2008 13:56:22 +0200 (CEST) Date: Mon, 8 Sep 2008 13:56:14 +0200 (CEST) From: Vaeth To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [RFC] Ability to pass arguments to src_configure/src_compile In-Reply-To: Message-ID: References: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Virus-Scanned: by amavisd-new at uni-wuerzburg.de X-Archives-Salt: 311293c6-7dd3-4039-83af-590852065f66 X-Archives-Hash: 45793b0ada35aa69c5eec7b3fce834da Santiago M. Mola wrote: > Vaeth wrote: > > > > [...] The suggestion violates in an extreme way the golden design > > rule that small changes in effect should require small changes in source. [...] > Yes, you're right. That would be really tedious and stupid... but > we're lucky, and EAPI-2 introduced the 'default' function. So if you > need to do a small change not covered by this method, you just define > the phase, make the little change, and then call the 'default' > function. Clean and simple. How does this "little change" look like if you have to call ./autogen.sh instead of ./configure? Or if you want to call a second ./configure in some subdirectory with the same options but one option changed? These are just some examples, I hope that the point becomes clear: You simply cannot cover all natural modifications which might be necessary unless you really can access the commands themselves; and for this reason it is wise IMHO to have default functions which are as short as possible (and which are in particular not dealing with complex implicit array arguments).