From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([69.77.167.62] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1Kcbmp-0004o2-7Z for garchives@archives.gentoo.org; Mon, 08 Sep 2008 08:07:51 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id E051CE02BD; Mon, 8 Sep 2008 08:07:49 +0000 (UTC) Received: from mailrelay.rz.uni-wuerzburg.de (wrzx28.rz.uni-wuerzburg.de [132.187.3.28]) by pigeon.gentoo.org (Postfix) with ESMTP id 9A846E02BD for ; Mon, 8 Sep 2008 08:07:49 +0000 (UTC) Received: from virusscan.mail (localhost [127.0.0.1]) by mailrelay.mail (Postfix) with ESMTP id 8455FA0722 for ; Mon, 8 Sep 2008 10:07:48 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by virusscan.mail (Postfix) with ESMTP id 77D5CA071B for ; Mon, 8 Sep 2008 10:07:48 +0200 (CEST) Received: from wmax001.mathematik.uni-wuerzburg.de (wmax001.mathematik.uni-wuerzburg.de [132.187.61.1]) by mailmaster.uni-wuerzburg.de (Postfix) with ESMTP id 62C17A06F5 for ; Mon, 8 Sep 2008 10:07:48 +0200 (CEST) Date: Mon, 8 Sep 2008 10:07:40 +0200 (CEST) From: Vaeth To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [RFC] Ability to pass arguments to src_configure/src_compile In-Reply-To: Message-ID: References: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Virus-Scanned: by amavisd-new at uni-wuerzburg.de X-Archives-Salt: c14635fa-c530-4d47-8c99-547970bd2475 X-Archives-Hash: 33c7d3776040edd062bf5244cbd87b30 > Yes. And here another point should be brought up. This proposal should > be wider and consider similar changes for the most common used > operations on all phases. And in fact, the most common used operations on all phases are already covered: Namely, this is the default implementation of the phase. Any change from this is not so common and should therefore be based on writing the function. Saving here some characters for typing the function header means to save at the wrong place by making everything less readable and less maintainable. (Moreover, in most cases, this would not even save some characters, because the variable names would have to be much longer...) Actually, too many variables with a predefined meaning are used in ebuilds already now. The original intention of ebuilds was that - in contrast to .spec-files or other stuff which are some sort of extended database - it should be simple pure shell code which everybody can easily read or write without filling in magic data. Things like WANT_AUTOMAKE=1.8 already violate this rule, but it seems hard to avoid it here, because IIRC there is no "src_depend()" function where the calculation of the dependencies could be done in a consistent manner. But the rule should not be violated without any serious need: If ebuilds consist only in setting magic variables, you can use .spec as well.