From: "Michael Sterrett -Mr. Bones.-" <msterret@coat.com>
To: Eldad Zack <eldad@gentoo.org>
Cc: gentoo-dev@lists.gentoo.org
Subject: [gentoo-dev] Re: CUSTOM cflags replacement snippet
Date: Sat, 20 Nov 2004 06:49:25 -0500 (EST) [thread overview]
Message-ID: <Pine.LNX.4.58.0411200646460.24610@rutrow.coat.com> (raw)
In-Reply-To: <200411201331.45499.eldad@gentoo.org>
On Sat, 20 Nov 2004, Eldad Zack wrote:
> for makefile in $(find -name "Makefile" .)
> do
> sed -i \
> -e "s:^CFLAGS.*:CFLAGS = ${CFLAGS}:" \
> -e "s:^CXXFLAGS.*:CXXFLAGS = ${CXXFLAGS}:" \
> ${makefile} \
> || die "Could not patch ${makefile} for custom CFLAGS"
> done
This stuff all fails if C*FLAGS has a ':' in it. There's a bug about
bad sed like this in bugzilla.
Also, sed takes a list. So never loop when you can just pass all the files
to sed. And don't forget about filenames with whitespace in the name...
Michael Sterrett
-Mr. Bones.-
mr_bones_@gentoo.org
--
gentoo-dev@gentoo.org mailing list
next prev parent reply other threads:[~2004-11-20 11:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-20 6:14 [gentoo-dev] CUSTOM cflags replacement snippet Chris White
2004-11-20 11:28 ` Eldad Zack
2004-11-20 11:31 ` Eldad Zack
2004-11-20 11:49 ` Michael Sterrett -Mr. Bones.- [this message]
2004-11-20 15:18 ` Georgi Georgiev
2004-11-22 5:30 ` Aron Griffis
2004-11-22 18:27 ` Aron Griffis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0411200646460.24610@rutrow.coat.com \
--to=msterret@coat.com \
--cc=eldad@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox