From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gentoo-dev-return-1073-arch-gentoo-dev=gentoo.org@gentoo.org>
Received: (qmail 16488 invoked by uid 1002); 11 Jan 2003 07:04:16 -0000
Mailing-List: contact gentoo-dev-help@gentoo.org; run by ezmlm
Precedence: bulk
List-Post: <mailto:gentoo-dev@gentoo.org>
List-Help: <mailto:gentoo-dev-help@gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev-unsubscribe@gentoo.org>
List-Subscribe: <mailto:gentoo-dev-subscribe@gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@gentoo.org
Received: (qmail 17717 invoked from network); 11 Jan 2003 07:04:02 -0000
Date: Sat, 11 Jan 2003 00:02:55 -0700 (MST)
From: "J.D. McGregor" <jade_e@perlstorm.net>
To: gentoo-dev@gentoo.org
Message-ID: <Pine.LNX.4.51L0.0301110002250.15602@rake.lotech.org>
MIME-Version: 1.0
Content-Type: MULTIPART/MIXED; BOUNDARY="-1446096800-513262788-1042266214=:3833"
Content-ID: <Pine.LNX.4.51L0.0301102324280.3833@rake.lotech.org>
Subject: [gentoo-dev] Re: [PATCH] USE aware emerge
X-Archives-Salt: 4e2c6224-540e-436b-a037-ccb296051d36
X-Archives-Hash: 1460e6e82ff16bfe8ec98558ff456aa0

---1446096800-513262788-1042266214=:3833
Content-Type: TEXT/PLAIN; CHARSET=US-ASCII
Content-ID: <Pine.LNX.4.51L0.0301102324281.3833@rake.lotech.org>

May I suggest this minor modification.  With the original code, if the
same flag comes up twice as either 'disabled' or 'unset' it gets added as
'enabled', since it fails the string.find() duplicate check, and there's
only a dup check on the fallthrough to 'enabled'.  The simple patch
enclosed fixes this.

Other than that, this is a great idea, works well, I'd love to see it
included.

-J.D.
>Well, semi use aware anyway.
>
>What do you think?
>
>
>$ ./emerge -p mozilla
>
>These are the packages that I would merge, in order:
>
>Calculating dependencies ...done!
>[ebuild   R  ] net-www/mozilla-1.2.1-r4
.
>
>The following USE flags for this action are:
>
>[enabled] java crypt gtk2 ssl gnome
>[disabled] ipv6
>[unset] ldap mozsvg mozcalendar mozaccess mozinterfaceinfo mozp3p
>mozxmlterm moznoirc moznomail moznocompose moznoxft
>
<etc etc etc>
---1446096800-513262788-1042266214=:3833
Content-Type: TEXT/PLAIN; CHARSET=US-ASCII; NAME=emergediff
Content-Transfer-Encoding: BASE64
Content-ID: <Pine.LNX.4.51L0.0301102351400.3833@rake.lotech.org>
Content-Description: code diff
Content-Disposition: ATTACHMENT; FILENAME=emergediff

LS0tIC93b3JrL3BvcnRhZ2UtMi4wLjQ2LXI0L2Jpbi9lbWVyZ2Uub2xkCTIw
MDMtMDEtMTAgMjM6NDU6MjguMDAwMDAwMDAwICswMDAwDQorKysgL3dvcmsv
cG9ydGFnZS0yLjAuNDYtcjQvYmluL2VtZXJnZQkyMDAzLTAxLTEwIDIzOjQ2
OjIwLjAwMDAwMDAwMCArMDAwMA0KQEAgLTE1NzEsNyArMTU3MSw3IEBADQog
CQkJCQkJZGlzYWJsZWQgPSBkaXNhYmxlZCArIHB1cnBsZSh5KSArICIgIg0K
IAkJCQkJZWxpZiBub3QgeSBpbiBwb3J0YWdlLnNldHRpbmdzWyJVU0UiXS5z
cGxpdCgpIGFuZCBzdHJpbmcuZmluZCh1bnNldCwgeSkgPCAwOg0KIAkJCQkJ
CXVuc2V0ID0gdW5zZXQgKyByZWQoeSkgKyAiICINCi0JCQkJCWVsaWYgc3Ry
aW5nLmZpbmQoZW5hYmxlZCwgeSkgPCAwOg0KKwkJCQkJZWxpZiB5IGluIHBv
cnRhZ2Uuc2V0dGluZ3NbIlVTRSJdLnNwbGl0KCkgYW5kIHN0cmluZy5maW5k
KGVuYWJsZWQsIHkpIDwgMDoNCiAJCQkJCQllbmFibGVkID0gZW5hYmxlZCAr
IGdyZWVuKHkpICsgIiAiDQogDQogCQlwcmludCBkYXJrZ3JlZW4oIlxuXG5U
aGUgZm9sbG93aW5nIFVTRSBmbGFncyBmb3IgdGhpcyBhY3Rpb24gYXJlOlxu
IikNCg==


---1446096800-513262788-1042266214=:3833
Content-Type: text/plain; charset=us-ascii

--
gentoo-dev@gentoo.org mailing list
---1446096800-513262788-1042266214=:3833--