[gentoo-dev] Re: [PATCH] USE aware emerge

["J.D. McGregor" <jade_e@perlstorm.net>]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 849 bytes --]

May I suggest this minor modification.  With the original code, if the
same flag comes up twice as either 'disabled' or 'unset' it gets added as
'enabled', since it fails the string.find() duplicate check, and there's
only a dup check on the fallthrough to 'enabled'.  The simple patch
enclosed fixes this.

Other than that, this is a great idea, works well, I'd love to see it
included.

-J.D.
>Well, semi use aware anyway.
>
>What do you think?
>
>
>$ ./emerge -p mozilla
>
>These are the packages that I would merge, in order:
>
>Calculating dependencies ...done!
>[ebuild   R  ] net-www/mozilla-1.2.1-r4
.
>
>The following USE flags for this action are:
>
>[enabled] java crypt gtk2 ssl gnome
>[disabled] ipv6
>[unset] ldap mozsvg mozcalendar mozaccess mozinterfaceinfo mozp3p
>mozxmlterm moznoirc moznomail moznocompose moznoxft
>
<etc etc etc>

[-- Attachment #2: code diff --]
[-- Type: TEXT/PLAIN, Size: 589 bytes --]

--- /work/portage-2.0.46-r4/bin/emerge.old	2003-01-10 23:45:28.000000000 +0000
+++ /work/portage-2.0.46-r4/bin/emerge	2003-01-10 23:46:20.000000000 +0000
@@ -1571,7 +1571,7 @@
 						disabled = disabled + purple(y) + " "
 					elif not y in portage.settings["USE"].split() and string.find(unset, y) < 0:
 						unset = unset + red(y) + " "
-					elif string.find(enabled, y) < 0:
+					elif y in portage.settings["USE"].split() and string.find(enabled, y) < 0:
 						enabled = enabled + green(y) + " "
 
 		print darkgreen("\n\nThe following USE flags for this action are:\n")

[-- Attachment #3: Type: text/plain, Size: 37 bytes --]

--
gentoo-dev@gentoo.org mailing list