From: "Michał Górny" <mgorny@gentoo.org>
To: gentoo-dev@lists.gentoo.org,Ulrich Mueller <ulm@gentoo.org>
Subject: Re: [gentoo-dev] [PATCH] eutils.eclass: Show death notice only when user patches were really applied
Date: Mon, 22 Aug 2016 13:48:36 +0200 [thread overview]
Message-ID: <CC0B0BCF-C74A-4A42-B7D3-656636199814@gentoo.org> (raw)
In-Reply-To: <22458.57100.705640.712139@a1i15.kph.uni-mainz.de>
Dnia 22 sierpnia 2016 13:16:28 CEST, Ulrich Mueller <ulm@gentoo.org> napisał(a):
>>>>>> On Mon, 22 Aug 2016, Thomas Deutschmann wrote:
>
>> On 2016-08-22 09:30, Ulrich Mueller wrote:
>>> I wonder if extending an obsolete feature is worth the effort.
>>> In EAPI 6, epatch_user has been replaced by eapply_user.
>
>> Well, I created the patch in November 2015 but never submitted it.
>> Yesterday someone in #gentoo-dev also asked about that
>> false-positive warning...
>
>> Yes, EAPI >=6 doesn't have this problem anymore. But many system
>> packages won't migrate to EAPI=6 very soon. So this irritating
>> warning will stay for the next years if we don't fix it. And because
>> it is an easy fix... isn't it?
>
>Sure, it is an easy fix. However, it is not without cost, as it adds
>another variable to global scope of all ebuilds inheriting eutils.
>Even in EAPI 6 where epatch_user will not be used.
But then, epatch shouldn't be used either.
>
>>>> + : $(( EPATCH_N_APPLIED_PATCHES++ ))
>>>
>>> Why not simply:
>>> (( EPATCH_N_APPLIED_PATCHES++ ))
>
>> When I created the patch I tried to use the same coding style. See
>
>>> : $(( count++ ))
>
>> two lines above.
>
>git blame point to the following commit:
>2975c21ee (Mike Frysinger 2010-01-09 20:06:24 +0000 595) : $(( count++
>))
>
>Looks like this was missed during eclass review back then. (I cannot
>find anything in the mailing list archives, though. Can anyone provide
>a pointer?)
vapier and review? Are you asking seriously?
>
>> Can I keep this or should I change?
>
>*shrug* It's a tiny issue.
>
>Ulrich
--
Best regards,
Michał Górny (by phone)
next prev parent reply other threads:[~2016-08-22 11:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-21 22:14 [gentoo-dev] [PATCH] eutils.eclass: Show death notice only when user patches were really applied Thomas Deutschmann
2016-08-22 7:30 ` Ulrich Mueller
2016-08-22 10:11 ` Thomas Deutschmann
2016-08-22 11:16 ` Ulrich Mueller
2016-08-22 11:48 ` Michał Górny [this message]
2016-08-22 17:29 ` [gentoo-dev] [PATCH v2] " Thomas Deutschmann
2016-08-23 17:25 ` [gentoo-dev] [PATCH v3] " Thomas Deutschmann
2016-08-23 17:25 ` Thomas Deutschmann
2016-08-31 16:46 ` Thomas Deutschmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CC0B0BCF-C74A-4A42-B7D3-656636199814@gentoo.org \
--to=mgorny@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
--cc=ulm@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox