From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 22840138334 for ; Thu, 13 Sep 2018 17:58:22 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 2F465E0AB7; Thu, 13 Sep 2018 17:58:17 +0000 (UTC) Received: from mail-oi0-f67.google.com (mail-oi0-f67.google.com [209.85.218.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id C44F2E0A91 for ; Thu, 13 Sep 2018 17:58:16 +0000 (UTC) Received: by mail-oi0-f67.google.com with SMTP id v198-v6so10274728oif.9 for ; Thu, 13 Sep 2018 10:58:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=/zbFjnEqLjj2z9Xlg8vKtLzf+oqUk8IUEbrcf+NDifQ=; b=PgckckMXEtZpkl26Be7a6MCbMWiwIpjSEat+/Phemv2jg9Lsg2t20r4HyKVQUCYMMz ddVzzg4fE3JlZHimogshaoG0WIWLjp5thLd0rsmieYyC67g5p+mbfSOZR/KR/FouWrb1 VNtj1BlY5x/ex4cDmNH1gnhmPYl4h2Psd6VzJqcFmDgieAqZTknPpgfqP13A4L/98Xs7 xLTpKGyaI7UhVeX1JmFUNnCNayHGvJAK0vHoek7AVi0z9NGu0Way6eVsN+X/AQ1XewjZ zurW2xZ3bj/E3a+edOrSF02BRsK5obEd0wvSr2PBCmaOihGou/vRhma1Q3xRa6Oa3Efd k5MA== X-Gm-Message-State: APzg51Ab46f7CLVzfeBS74P+HuVU84MX2Jlh8aZvGHGZif0ZEtrNX6Tm /bQwUcsjK01BaUL+C6v5Asm5W5IJH5OW+cKynKtCug== X-Google-Smtp-Source: ANB0VdYDC4rSffLn9aZ1hHPW4ikKDp3G8EQlUMRiBE+Jy4JL9tiscmu9NgBkQtBzUtPE3rpF5C04kAUDrYiVKldRw3w= X-Received: by 2002:aca:ec0d:: with SMTP id k13-v6mr7565860oih.236.1536861495337; Thu, 13 Sep 2018 10:58:15 -0700 (PDT) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 References: <20180912085649.GA16516@baraddur.perfinion.com> <6c18c6bd-4cf3-dff6-2f20-c021063e01fa@gentoo.org> <20180913155123.GB26329@gentoo.org> <20180913162048.GE26329@gentoo.org> In-Reply-To: <20180913162048.GE26329@gentoo.org> From: Alon Bar-Lev Date: Thu, 13 Sep 2018 20:58:02 +0300 Message-ID: Subject: Re: [gentoo-dev] Changing policy about -Werror To: gentoo-dev@lists.gentoo.org Content-Type: text/plain; charset="UTF-8" X-Archives-Salt: b8a7d364-f5ee-40bb-a246-ea6a46aef10c X-Archives-Hash: d115f4052301e63b23f762aac6fafb92 On Thu, Sep 13, 2018 at 7:20 PM Fabian Groffen wrote: > > > To illustrate harmless: > > > warning: this statement may fall through [-Wimplicit-fallthrough=] > > > The warning message already has it in it that it's just a pure guess. > > > > One that exposed a lot of unintentional fallthoughs which were fixed > > when reporting to upstream. > > Sure that's why the warning is there. But you ignore the point that the > same code compiled fine and ran fine for years without problems. The fact that something is compiling and running fine meaning there are no issues (bugs) within code? Seriously? Even after no-warning with multiple compiler vendors, code coverage, unit testing, test on various of architecture developer has access to, static code analysis and running for years, bugs are there. Any method to help detect suspicious code, even if it produces amount of false positive, must be embraced of those who care about quality. New toolchains, new scanners, new architectures all can help to improve quality to make sure great service is provided to users. In Gentoo language, all these issues should be detected for selected packages by non-stable users, on architecture and permutations that upstream do not have access to, and to help upstream to filter false positives and find the positives ones. Even one case of funding real issue is sufficient to justify the maintenance costs, once again for selected packages in which upstream following strict quality policy and downstream follows. Once policy is applied, the amount of noise is very little, toolchain evolution is not as it was 10 years ago. Regards, Alon