From: Alon Bar-Lev <alonbl@gentoo.org>
To: ryao@gentoo.org
Cc: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] Changing policy about -Werror
Date: Fri, 14 Sep 2018 20:22:11 +0300 [thread overview]
Message-ID: <CAOazyz03wKGqF1d65XcxG9JC2dDQHUhzj_eS4XqL7DVSJa5hLQ@mail.gmail.com> (raw)
In-Reply-To: <4318377f-9428-d79a-3ba3-5b2c1ad68166@gentoo.org>
On Fri, Sep 14, 2018 at 8:16 PM Richard Yao <ryao@gentoo.org> wrote:
>
> On 09/14/2018 12:40 PM, Alon Bar-Lev wrote:
> > On Fri, Sep 14, 2018 at 12:34 AM Sergei Trofimovich <slyfox@gentoo.org> wrote:
> >>
> >> On Tue, 11 Sep 2018 12:44:38 +0300
> >> Alon Bar-Lev <alonbl@gentoo.org> wrote:
> >>
> >> I'm personally in favour of not allowing -Werror
> >> to be in build system unconditionally.
> >>
> >> Maintainer is free to implement --enable-werror any way
> >> it's convenient to run on their own extended sanity checks
> >> and optionally expose it to users. Be it USE flag or
> >> EXTRA_ECONF option.
> >
> > This discussion is not for downstream to have a more strict policy
> > than upstream. People try to hijack discussion and introduce noise to
> > de-focus the discussion.
> >
> > Downstream policy cannot be more strict than upstream as then every
> > change upstream is doing downstream need to rebase and invest in even
> > more changes.
> >
> > This discussion is to follow upstream strict policy if upstream proves
> > that it stands behind it and downstream is willing to follow.
> I don't think we should do that unless we provide a USE flag for users
> to opt into the behavior. Forcing it on users is problematic for the
> reasons others stated. However, letting them opt into the behavior is
> reasonable.
>
> In the case of sys-fs/zfs, enabling -Werror (which includes -Wall) on
> USE=debug is following upstream's wishes to build debug builds with -Werror.
Let's do this the other way around and be react based on facts and not
speculations.
Let's change the policy for a year for selected packages as I
outlined, monitor bugs and after a year see response times, affected
users and if downstream patches are accumulated. Then we can decide if
we need to patch upstream packages.
If we need to patch upstream package anyway, not follow upstream
policy and not accepting input for various of permutations and
architecture from all users, this discussion is nearly void.
next prev parent reply other threads:[~2018-09-14 17:22 UTC|newest]
Thread overview: 119+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-09 11:32 [gentoo-dev] Changing policy about -Werror Andrew Savchenko
2018-09-09 13:03 ` Thomas Deutschmann
2018-09-09 15:02 ` Andrew Savchenko
2018-09-09 16:32 ` Ulrich Mueller
2018-09-09 17:18 ` Richard Yao
2018-09-09 15:11 ` Jeroen Roovers
2018-09-09 15:22 ` Richard Yao
2018-09-09 16:11 ` Michał Górny
2018-09-09 17:09 ` Richard Yao
2018-09-09 17:24 ` Richard Yao
2018-09-09 17:13 ` Richard Yao
2018-09-12 20:28 ` Andreas K. Huettel
2018-09-12 21:54 ` Richard Yao
2018-09-10 14:19 ` Fabian Groffen
2018-09-10 21:18 ` Chí-Thanh Christopher Nguyễn
2018-09-10 21:44 ` Richard Yao
2018-09-10 21:42 ` Richard Yao
2018-09-09 16:31 ` Michał Górny
2018-09-09 23:46 ` Chí-Thanh Christopher Nguyễn
2018-09-10 7:45 ` Jason Zaman
2018-09-10 20:34 ` Chí-Thanh Christopher Nguyễn
2018-09-10 20:51 ` Matt Turner
2018-09-10 20:56 ` Kristian Fiskerstrand
2018-09-10 20:59 ` Mart Raudsepp
2018-09-10 21:26 ` Chí-Thanh Christopher Nguyễn
2018-09-10 21:43 ` Richard Yao
2018-09-10 21:01 ` Kristian Fiskerstrand
2018-09-10 21:01 ` Mike Gilbert
2018-09-10 21:04 ` Kristian Fiskerstrand
2018-09-10 21:10 ` Kristian Fiskerstrand
2018-09-11 0:50 ` Thomas Deutschmann
2018-09-10 21:31 ` Rich Freeman
2018-09-10 21:33 ` Kristian Fiskerstrand
2018-09-10 21:58 ` Mike Gilbert
2018-09-10 21:19 ` Chí-Thanh Christopher Nguyễn
2018-09-10 21:21 ` Kristian Fiskerstrand
2018-09-10 21:27 ` Kristian Fiskerstrand
2018-09-10 21:48 ` Richard Yao
2018-09-10 21:52 ` Richard Yao
2018-09-10 21:35 ` Chí-Thanh Christopher Nguyễn
2018-09-10 21:41 ` Kristian Fiskerstrand
2018-09-12 8:56 ` Jason Zaman
2018-09-12 14:50 ` Rich Freeman
2018-09-12 16:47 ` Mike
2018-09-13 11:25 ` Ulrich Mueller
2018-09-13 13:29 ` Mike
2018-09-13 13:35 ` Rich Freeman
2018-09-13 13:39 ` Mike
2018-09-13 14:06 ` Ulrich Mueller
2018-09-12 22:55 ` Thomas Deutschmann
2018-09-12 23:03 ` Rich Freeman
2018-09-12 23:52 ` Matt Turner
2018-09-13 0:11 ` Rich Freeman
2018-09-13 0:46 ` Matt Turner
2018-09-13 15:51 ` Fabian Groffen
2018-09-13 15:56 ` Alon Bar-Lev
2018-09-13 16:20 ` Fabian Groffen
2018-09-13 17:58 ` Alon Bar-Lev
2018-09-14 0:41 ` Georg Rudoy
2018-09-12 23:47 ` Chí-Thanh Christopher Nguyễn
2018-09-13 11:36 ` Richard Yao
2018-09-13 16:03 ` Fabian Groffen
2018-09-13 23:12 ` Richard Yao
2018-09-13 23:21 ` Matt Turner
2018-09-14 0:44 ` Richard Yao
2018-09-14 0:54 ` Georg Rudoy
2018-09-14 17:09 ` Richard Yao
2018-09-14 3:35 ` Matt Turner
2018-09-14 15:54 ` Richard Yao
2018-09-14 23:07 ` Sergei Trofimovich
2018-09-14 23:27 ` Richard Yao
2018-09-21 22:33 ` Chí-Thanh Christopher Nguyễn
2018-09-22 5:57 ` Alon Bar-Lev
2018-09-14 17:47 ` Richard Yao
2018-09-14 17:58 ` Richard Yao
2018-09-13 15:48 ` Fabian Groffen
2018-09-09 17:50 ` Michael Orlitzky
2018-09-10 0:30 ` Rich Freeman
2018-09-09 20:47 ` Matt Turner
2018-09-10 0:13 ` Chí-Thanh Christopher Nguyễn
2018-09-11 6:15 ` Andreas K. Huettel
2018-09-11 9:44 ` Alon Bar-Lev
2018-09-12 23:32 ` Chí-Thanh Christopher Nguyễn
2018-09-13 0:09 ` Rich Freeman
2018-09-13 16:07 ` Fabian Groffen
2018-09-13 21:34 ` Sergei Trofimovich
2018-09-14 16:40 ` Alon Bar-Lev
2018-09-14 17:16 ` Richard Yao
2018-09-14 17:22 ` Alon Bar-Lev [this message]
2018-09-14 17:26 ` Rich Freeman
2018-09-14 17:33 ` Michał Górny
2018-09-14 17:48 ` Alon Bar-Lev
2018-09-14 17:53 ` Michał Górny
2018-09-14 18:00 ` Alon Bar-Lev
2018-09-14 17:52 ` Rich Freeman
2018-09-14 19:29 ` Michael Orlitzky
2018-09-14 19:58 ` Richard Yao
2018-09-14 20:20 ` Michael Orlitzky
2018-09-14 20:29 ` Rich Freeman
2018-09-14 21:02 ` Fabian Groffen
2018-09-14 21:07 ` Alon Bar-Lev
2018-09-14 21:28 ` Fabian Groffen
2018-09-14 21:46 ` Alon Bar-Lev
2018-09-14 22:45 ` Fabian Groffen
2018-09-14 22:14 ` Richard Yao
2018-09-14 22:58 ` Alon Bar-Lev
2018-09-14 22:11 ` Richard Yao
2018-09-14 19:53 ` Sergei Trofimovich
2018-09-14 20:15 ` Alon Bar-Lev
2018-09-14 23:43 ` Sergei Trofimovich
2018-09-12 23:35 ` [gentoo-dev] acceptable alternatives to -Werror, was: " Chí-Thanh Christopher Nguyễn
2018-09-13 0:14 ` Rich Freeman
2018-09-13 0:23 ` Chí-Thanh Christopher Nguyễn
2018-09-13 0:34 ` Rich Freeman
2018-09-13 0:43 ` Chí-Thanh Christopher Nguyễn
2018-09-13 8:49 ` Mike Auty
2018-09-21 22:42 ` Chí-Thanh Christopher Nguyễn
2018-09-13 11:47 ` Richard Yao
2018-09-13 19:32 ` [gentoo-dev] " Nikos Chantziaras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOazyz03wKGqF1d65XcxG9JC2dDQHUhzj_eS4XqL7DVSJa5hLQ@mail.gmail.com \
--to=alonbl@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
--cc=ryao@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox