From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1RMLRS-0004Eh-DZ for garchives@archives.gentoo.org; Fri, 04 Nov 2011 15:12:26 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id BAA0A21C08D; Fri, 4 Nov 2011 15:12:14 +0000 (UTC) Received: from mail-gy0-f181.google.com (mail-gy0-f181.google.com [209.85.160.181]) by pigeon.gentoo.org (Postfix) with ESMTP id 1AFC721C041 for ; Fri, 4 Nov 2011 15:11:42 +0000 (UTC) Received: by gyd10 with SMTP id 10so3283146gyd.40 for ; Fri, 04 Nov 2011 08:11:42 -0700 (PDT) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Received: by 10.236.190.197 with SMTP id e45mr21563500yhn.101.1320419502343; Fri, 04 Nov 2011 08:11:42 -0700 (PDT) Sender: lxnay@sabayonlinux.org Received: by 10.236.109.142 with HTTP; Fri, 4 Nov 2011 08:11:42 -0700 (PDT) In-Reply-To: <4EB3FAD6.4080203@gentoo.org> References: <4EB3E1A2.6040702@gentoo.org> <4EB3FAD6.4080203@gentoo.org> Date: Fri, 4 Nov 2011 16:11:42 +0100 X-Google-Sender-Auth: zsA-k-g9jKh6c6hPS-5HGzRKOvU Message-ID: Subject: Re: [gentoo-dev] linux-info.eclass: check_extra_config requires a configured kernel From: Fabio Erculiani To: gentoo-dev@lists.gentoo.org Content-Type: text/plain; charset=UTF-8 X-Archives-Salt: 3ddca611-aa2d-4b51-8da0-8958dee79464 X-Archives-Hash: b53b6f516a5bfebc1e2a6d010bee8a33 On Fri, Nov 4, 2011 at 3:46 PM, Mike Gilbert wrote: > > It is good that we warn users about this when they install the package, > but I don't think the ebuild should die. I've always found ebuilds dying at kernel config checks really annoying. Checking kernel features at build time (if we die) is broken and should be banned IMO: 1) in case of packages not needing kernel headers for building (but just checking for a feature) a) this breaks the compilation inside chroots on build servers where the goal is to just build the package (hint: binpkgs) b) it is anyway unable to reliably check if the feature is actually available or not (/proc/config.gz might be unavailable, as well as kernel sources or headers) 2) in case of packages needing kernel headers (or sources) for building a) doing the check in pkg_setup() breaks binpkgs support (the check becomes part of a build time task, and not install time) I'm sure there are other reasons as well... -- Fabio Erculiani http://lxnay.com