public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Fabio Erculiani <lxnay@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] linux-info.eclass: check_extra_config requires a configured kernel
Date: Fri, 4 Nov 2011 16:11:42 +0100	[thread overview]
Message-ID: <CAN3Atvoz5d5JLUGbnaL9mQbhqNjBxOh2xdUfN6zZ_t0UQW60cQ@mail.gmail.com> (raw)
In-Reply-To: <4EB3FAD6.4080203@gentoo.org>

On Fri, Nov 4, 2011 at 3:46 PM, Mike Gilbert <floppym@gentoo.org> wrote:
>
> It is good that we warn users about this when they install the package,
> but I don't think the ebuild should die.

I've always found ebuilds dying at kernel config checks really annoying.
Checking kernel features at build time (if we die) is broken and
should be banned IMO:

1) in case of packages not needing kernel headers for building (but
just checking for a feature)
a) this breaks the compilation inside chroots on build servers where
the goal is to just build the package (hint: binpkgs)
b) it is anyway unable to reliably check if the feature is actually
available or not (/proc/config.gz might be unavailable, as well as
kernel sources or headers)

2) in case of packages needing kernel headers (or sources) for building
a) doing the check in pkg_setup() breaks binpkgs support (the check
becomes part of a build time task, and not install time)

I'm sure there are other reasons as well...

-- 
Fabio Erculiani
http://lxnay.com



  reply	other threads:[~2011-11-04 15:12 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-04 12:59 [gentoo-dev] linux-info.eclass: check_extra_config requires a configured kernel "Paweł Hajdan, Jr."
2011-11-04 13:13 ` Fabio Erculiani
2011-11-04 13:23 ` Patrick Lauer
2011-11-04 13:33   ` Nirbheek Chauhan
2011-11-04 14:46 ` Mike Gilbert
2011-11-04 15:11   ` Fabio Erculiani [this message]
2011-11-04 15:29     ` Ian Stakenvicius
2011-11-04 15:54       ` Fabio Erculiani
2011-11-04 21:18     ` Robin H. Johnson
2011-11-04 22:02       ` Fabio Erculiani
2011-11-04 22:12         ` Robin H. Johnson
2011-11-04 22:16           ` Fabio Erculiani
2011-11-04 21:16 ` Robin H. Johnson
2011-11-05 23:14   ` Robin H. Johnson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAN3Atvoz5d5JLUGbnaL9mQbhqNjBxOh2xdUfN6zZ_t0UQW60cQ@mail.gmail.com \
    --to=lxnay@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox