public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
* [gentoo-dev] [PATCH] python-utils-r1.eclass: support PYTHON_IMPLS_NO_STRICT variable
@ 2017-05-02 21:48 Zac Medico
  2017-05-04 20:34 ` [gentoo-dev] " Zac Medico
  2017-05-16 17:19 ` [gentoo-dev] " Michał Górny
  0 siblings, 2 replies; 6+ messages in thread
From: Zac Medico @ 2017-05-02 21:48 UTC (permalink / raw
  To: gentoo-dev; +Cc: python, Zac Medico

This is intended to be set by the user when using ebuilds that may
have unknown implementations in PYTHON_COMPAT. The assumption is
that the ebuilds are intended to be used within multiple contexts
which can involve revisions of this eclass that support different
python implementations.
---
 eclass/python-utils-r1.eclass | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/eclass/python-utils-r1.eclass b/eclass/python-utils-r1.eclass
index 66a359e..1846da3 100644
--- a/eclass/python-utils-r1.eclass
+++ b/eclass/python-utils-r1.eclass
@@ -47,6 +47,21 @@ _PYTHON_ALL_IMPLS=(
 )
 readonly _PYTHON_ALL_IMPLS
 
+# @ECLASS-VARIABLE: PYTHON_IMPLS_NO_STRICT
+# @DESCRIPTION:
+# Tolerate unknown implementations in PYTHON_COMPAT.
+#
+# This is intended to be set by the user when using ebuilds that may
+# have unknown implementations in PYTHON_COMPAT. The assumption is
+# that the ebuilds are intended to be used within multiple contexts
+# which can involve revisions of this eclass that support different
+# python implementations.
+#
+# Example:
+# @CODE
+# PYTHON_IMPLS_NO_STRICT=1
+# @CODE
+
 # @FUNCTION: _python_impl_supported
 # @USAGE: <impl>
 # @INTERNAL
@@ -79,6 +94,7 @@ _python_impl_supported() {
 			fi
 			;;
 		*)
+			[[ -n ${PYTHON_IMPLS_NO_STRICT} ]] && return 1
 			die "Invalid implementation in PYTHON_COMPAT: ${impl}"
 	esac
 }
-- 
2.10.2



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [gentoo-dev] Re: [PATCH] python-utils-r1.eclass: support PYTHON_IMPLS_NO_STRICT variable
  2017-05-02 21:48 [gentoo-dev] [PATCH] python-utils-r1.eclass: support PYTHON_IMPLS_NO_STRICT variable Zac Medico
@ 2017-05-04 20:34 ` Zac Medico
  2017-05-05  5:29   ` Michał Górny
  2017-05-16 17:19 ` [gentoo-dev] " Michał Górny
  1 sibling, 1 reply; 6+ messages in thread
From: Zac Medico @ 2017-05-04 20:34 UTC (permalink / raw
  To: gentoo-dev; +Cc: python, Zac Medico

[-- Attachment #1: Type: text/plain, Size: 1718 bytes --]

On Tue, May 2, 2017 at 2:48 PM, Zac Medico <zmedico@gentoo.org> wrote:

> This is intended to be set by the user when using ebuilds that may
> have unknown implementations in PYTHON_COMPAT. The assumption is
> that the ebuilds are intended to be used within multiple contexts
> which can involve revisions of this eclass that support different
> python implementations.
> ---
>  eclass/python-utils-r1.eclass | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>
> diff --git a/eclass/python-utils-r1.eclass b/eclass/python-utils-r1.eclass
> index 66a359e..1846da3 100644
> --- a/eclass/python-utils-r1.eclass
> +++ b/eclass/python-utils-r1.eclass
> @@ -47,6 +47,21 @@ _PYTHON_ALL_IMPLS=(
>  )
>  readonly _PYTHON_ALL_IMPLS
>
> +# @ECLASS-VARIABLE: PYTHON_IMPLS_NO_STRICT
> +# @DESCRIPTION:
> +# Tolerate unknown implementations in PYTHON_COMPAT.
> +#
> +# This is intended to be set by the user when using ebuilds that may
> +# have unknown implementations in PYTHON_COMPAT. The assumption is
> +# that the ebuilds are intended to be used within multiple contexts
> +# which can involve revisions of this eclass that support different
> +# python implementations.
> +#
> +# Example:
> +# @CODE
> +# PYTHON_IMPLS_NO_STRICT=1
> +# @CODE
> +
>  # @FUNCTION: _python_impl_supported
>  # @USAGE: <impl>
>  # @INTERNAL
> @@ -79,6 +94,7 @@ _python_impl_supported() {
>                         fi
>                         ;;
>                 *)
> +                       [[ -n ${PYTHON_IMPLS_NO_STRICT} ]] && return 1
>                         die "Invalid implementation in PYTHON_COMPAT:
> ${impl}"
>         esac
>  }
> --
> 2.10.2
>
>
If nobody objects, I'd like to merge this sometime next week.
-- 
Thanks,
Zac

[-- Attachment #2: Type: text/html, Size: 2416 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [gentoo-dev] Re: [PATCH] python-utils-r1.eclass: support PYTHON_IMPLS_NO_STRICT variable
  2017-05-04 20:34 ` [gentoo-dev] " Zac Medico
@ 2017-05-05  5:29   ` Michał Górny
  2017-05-05  6:53     ` Zac Medico
  0 siblings, 1 reply; 6+ messages in thread
From: Michał Górny @ 2017-05-05  5:29 UTC (permalink / raw
  To: gentoo-dev, Zac Medico; +Cc: python

Dnia 4 maja 2017 22:34:56 CEST, Zac Medico <zmedico@gentoo.org> napisał(a):
>On Tue, May 2, 2017 at 2:48 PM, Zac Medico <zmedico@gentoo.org> wrote:
>
>> This is intended to be set by the user when using ebuilds that may
>> have unknown implementations in PYTHON_COMPAT. The assumption is
>> that the ebuilds are intended to be used within multiple contexts
>> which can involve revisions of this eclass that support different
>> python implementations.
>> ---
>>  eclass/python-utils-r1.eclass | 16 ++++++++++++++++
>>  1 file changed, 16 insertions(+)
>>
>> diff --git a/eclass/python-utils-r1.eclass
>b/eclass/python-utils-r1.eclass
>> index 66a359e..1846da3 100644
>> --- a/eclass/python-utils-r1.eclass
>> +++ b/eclass/python-utils-r1.eclass
>> @@ -47,6 +47,21 @@ _PYTHON_ALL_IMPLS=(
>>  )
>>  readonly _PYTHON_ALL_IMPLS
>>
>> +# @ECLASS-VARIABLE: PYTHON_IMPLS_NO_STRICT
>> +# @DESCRIPTION:
>> +# Tolerate unknown implementations in PYTHON_COMPAT.
>> +#
>> +# This is intended to be set by the user when using ebuilds that may
>> +# have unknown implementations in PYTHON_COMPAT. The assumption is
>> +# that the ebuilds are intended to be used within multiple contexts
>> +# which can involve revisions of this eclass that support different
>> +# python implementations.
>> +#
>> +# Example:
>> +# @CODE
>> +# PYTHON_IMPLS_NO_STRICT=1
>> +# @CODE
>> +
>>  # @FUNCTION: _python_impl_supported
>>  # @USAGE: <impl>
>>  # @INTERNAL
>> @@ -79,6 +94,7 @@ _python_impl_supported() {
>>                         fi
>>                         ;;
>>                 *)
>> +                       [[ -n ${PYTHON_IMPLS_NO_STRICT} ]] && return
>1
>>                         die "Invalid implementation in PYTHON_COMPAT:
>> ${impl}"
>>         esac
>>  }
>> --
>> 2.10.2
>>
>>
>If nobody objects, I'd like to merge this sometime next week.

If there's no explicit hurry, I'd like to commit it along with other python patch I'll be writing soon, to avoid multiple cache regens.


-- 
Best regards,
Michał Górny (by phone)


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [gentoo-dev] Re: [PATCH] python-utils-r1.eclass: support PYTHON_IMPLS_NO_STRICT variable
  2017-05-05  5:29   ` Michał Górny
@ 2017-05-05  6:53     ` Zac Medico
  0 siblings, 0 replies; 6+ messages in thread
From: Zac Medico @ 2017-05-05  6:53 UTC (permalink / raw
  To: Michał Górny; +Cc: gentoo-dev, python

[-- Attachment #1: Type: text/plain, Size: 2275 bytes --]

On Thu, May 4, 2017 at 10:29 PM, Michał Górny <mgorny@gentoo.org> wrote:

> Dnia 4 maja 2017 22:34:56 CEST, Zac Medico <zmedico@gentoo.org>
> napisał(a):
> >On Tue, May 2, 2017 at 2:48 PM, Zac Medico <zmedico@gentoo.org> wrote:
> >
> >> This is intended to be set by the user when using ebuilds that may
> >> have unknown implementations in PYTHON_COMPAT. The assumption is
> >> that the ebuilds are intended to be used within multiple contexts
> >> which can involve revisions of this eclass that support different
> >> python implementations.
> >> ---
> >>  eclass/python-utils-r1.eclass | 16 ++++++++++++++++
> >>  1 file changed, 16 insertions(+)
> >>
> >> diff --git a/eclass/python-utils-r1.eclass
> >b/eclass/python-utils-r1.eclass
> >> index 66a359e..1846da3 100644
> >> --- a/eclass/python-utils-r1.eclass
> >> +++ b/eclass/python-utils-r1.eclass
> >> @@ -47,6 +47,21 @@ _PYTHON_ALL_IMPLS=(
> >>  )
> >>  readonly _PYTHON_ALL_IMPLS
> >>
> >> +# @ECLASS-VARIABLE: PYTHON_IMPLS_NO_STRICT
> >> +# @DESCRIPTION:
> >> +# Tolerate unknown implementations in PYTHON_COMPAT.
> >> +#
> >> +# This is intended to be set by the user when using ebuilds that may
> >> +# have unknown implementations in PYTHON_COMPAT. The assumption is
> >> +# that the ebuilds are intended to be used within multiple contexts
> >> +# which can involve revisions of this eclass that support different
> >> +# python implementations.
> >> +#
> >> +# Example:
> >> +# @CODE
> >> +# PYTHON_IMPLS_NO_STRICT=1
> >> +# @CODE
> >> +
> >>  # @FUNCTION: _python_impl_supported
> >>  # @USAGE: <impl>
> >>  # @INTERNAL
> >> @@ -79,6 +94,7 @@ _python_impl_supported() {
> >>                         fi
> >>                         ;;
> >>                 *)
> >> +                       [[ -n ${PYTHON_IMPLS_NO_STRICT} ]] && return
> >1
> >>                         die "Invalid implementation in PYTHON_COMPAT:
> >> ${impl}"
> >>         esac
> >>  }
> >> --
> >> 2.10.2
> >>
> >>
> >If nobody objects, I'd like to merge this sometime next week.
>
> If there's no explicit hurry, I'd like to commit it along with other
> python patch I'll be writing soon, to avoid multiple cache regens.
>

That works for me. Thank you!
-- 
Thanks,
Zac

[-- Attachment #2: Type: text/html, Size: 3388 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [gentoo-dev] [PATCH] python-utils-r1.eclass: support PYTHON_IMPLS_NO_STRICT variable
  2017-05-02 21:48 [gentoo-dev] [PATCH] python-utils-r1.eclass: support PYTHON_IMPLS_NO_STRICT variable Zac Medico
  2017-05-04 20:34 ` [gentoo-dev] " Zac Medico
@ 2017-05-16 17:19 ` Michał Górny
  2017-05-16 17:21   ` Zac Medico
  1 sibling, 1 reply; 6+ messages in thread
From: Michał Górny @ 2017-05-16 17:19 UTC (permalink / raw
  To: gentoo-dev; +Cc: python, Zac Medico

[-- Attachment #1: Type: text/plain, Size: 1719 bytes --]

On wto, 2017-05-02 at 14:48 -0700, Zac Medico wrote:
> This is intended to be set by the user when using ebuilds that may
> have unknown implementations in PYTHON_COMPAT. The assumption is
> that the ebuilds are intended to be used within multiple contexts
> which can involve revisions of this eclass that support different
> python implementations.
> ---
>  eclass/python-utils-r1.eclass | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/eclass/python-utils-r1.eclass b/eclass/python-utils-r1.eclass
> index 66a359e..1846da3 100644
> --- a/eclass/python-utils-r1.eclass
> +++ b/eclass/python-utils-r1.eclass
> @@ -47,6 +47,21 @@ _PYTHON_ALL_IMPLS=(
>  )
>  readonly _PYTHON_ALL_IMPLS
>  
> +# @ECLASS-VARIABLE: PYTHON_IMPLS_NO_STRICT
> +# @DESCRIPTION:
> +# Tolerate unknown implementations in PYTHON_COMPAT.
> +#
> +# This is intended to be set by the user when using ebuilds that may
> +# have unknown implementations in PYTHON_COMPAT. The assumption is
> +# that the ebuilds are intended to be used within multiple contexts
> +# which can involve revisions of this eclass that support different
> +# python implementations.
> +#
> +# Example:
> +# @CODE
> +# PYTHON_IMPLS_NO_STRICT=1
> +# @CODE
> +
>  # @FUNCTION: _python_impl_supported
>  # @USAGE: <impl>
>  # @INTERNAL
> @@ -79,6 +94,7 @@ _python_impl_supported() {
>  			fi
>  			;;
>  		*)
> +			[[ -n ${PYTHON_IMPLS_NO_STRICT} ]] && return 1
>  			die "Invalid implementation in PYTHON_COMPAT: ${impl}"
>  	esac
>  }

I've changed the name to PYTHON_COMPAT_NO_STRICT to fit the eclasses
better, and marked it @INTERNAL. Otherwise, committed now.

-- 
Best regards,
Michał Górny

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 963 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [gentoo-dev] [PATCH] python-utils-r1.eclass: support PYTHON_IMPLS_NO_STRICT variable
  2017-05-16 17:19 ` [gentoo-dev] " Michał Górny
@ 2017-05-16 17:21   ` Zac Medico
  0 siblings, 0 replies; 6+ messages in thread
From: Zac Medico @ 2017-05-16 17:21 UTC (permalink / raw
  To: Michał Górny; +Cc: gentoo-dev, python

[-- Attachment #1: Type: text/plain, Size: 1982 bytes --]

On Tue, May 16, 2017 at 10:19 AM, Michał Górny <mgorny@gentoo.org> wrote:

> On wto, 2017-05-02 at 14:48 -0700, Zac Medico wrote:
> > This is intended to be set by the user when using ebuilds that may
> > have unknown implementations in PYTHON_COMPAT. The assumption is
> > that the ebuilds are intended to be used within multiple contexts
> > which can involve revisions of this eclass that support different
> > python implementations.
> > ---
> >  eclass/python-utils-r1.eclass | 16 ++++++++++++++++
> >  1 file changed, 16 insertions(+)
> >
> > diff --git a/eclass/python-utils-r1.eclass b/eclass/python-utils-r1.
> eclass
> > index 66a359e..1846da3 100644
> > --- a/eclass/python-utils-r1.eclass
> > +++ b/eclass/python-utils-r1.eclass
> > @@ -47,6 +47,21 @@ _PYTHON_ALL_IMPLS=(
> >  )
> >  readonly _PYTHON_ALL_IMPLS
> >
> > +# @ECLASS-VARIABLE: PYTHON_IMPLS_NO_STRICT
> > +# @DESCRIPTION:
> > +# Tolerate unknown implementations in PYTHON_COMPAT.
> > +#
> > +# This is intended to be set by the user when using ebuilds that may
> > +# have unknown implementations in PYTHON_COMPAT. The assumption is
> > +# that the ebuilds are intended to be used within multiple contexts
> > +# which can involve revisions of this eclass that support different
> > +# python implementations.
> > +#
> > +# Example:
> > +# @CODE
> > +# PYTHON_IMPLS_NO_STRICT=1
> > +# @CODE
> > +
> >  # @FUNCTION: _python_impl_supported
> >  # @USAGE: <impl>
> >  # @INTERNAL
> > @@ -79,6 +94,7 @@ _python_impl_supported() {
> >                       fi
> >                       ;;
> >               *)
> > +                     [[ -n ${PYTHON_IMPLS_NO_STRICT} ]] && return 1
> >                       die "Invalid implementation in PYTHON_COMPAT:
> ${impl}"
> >       esac
> >  }
>
> I've changed the name to PYTHON_COMPAT_NO_STRICT to fit the eclasses
> better, and marked it @INTERNAL. Otherwise, committed now.


Okay, thanks!
-- 
Thanks,
Zac

[-- Attachment #2: Type: text/html, Size: 2733 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2017-05-16 17:23 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-02 21:48 [gentoo-dev] [PATCH] python-utils-r1.eclass: support PYTHON_IMPLS_NO_STRICT variable Zac Medico
2017-05-04 20:34 ` [gentoo-dev] " Zac Medico
2017-05-05  5:29   ` Michał Górny
2017-05-05  6:53     ` Zac Medico
2017-05-16 17:19 ` [gentoo-dev] " Michał Górny
2017-05-16 17:21   ` Zac Medico

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox