From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 4E481139694 for ; Tue, 16 May 2017 17:23:27 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 1683921C1BB; Tue, 16 May 2017 17:21:33 +0000 (UTC) Received: from mail-ua0-x244.google.com (mail-ua0-x244.google.com [IPv6:2607:f8b0:400c:c08::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id C92CCE0BA3 for ; Tue, 16 May 2017 17:21:27 +0000 (UTC) Received: by mail-ua0-x244.google.com with SMTP id i46so12761951uaa.3 for ; Tue, 16 May 2017 10:21:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=0S7HOs8dIFvnB5cybVXZwAHkW2prHPtWKJV/l+kKrEQ=; b=ZIWmZtBvHODdT+sNqdDcdiYbU5gh98rew2+yrAVN1cXtUtCc5w89dRJfqvDlnhh/d8 BFsonyaXq8msNQGZhRAnqZAX0lTVLfjTEWfsKujJrcoNIyoQsiHJtuJ4POGgdVJdUh2v YdXLuRYga524BYZ6oSRvruq7dIOT7lEDh7P/RWY23KzIyb5huaij4DFVAVW63hYZHmau Do4hSZWlYwEh8b3McAyYql0hfNv16o5uuoV9TUIHj8rYwENo3WJgZ800UoDSRP3dGEkf BBcNnMld16Wk+IQYyt+m+TmB1Qt3xCT2xrigJlmjPqqQlC5fV8Q7pBWBsOEE21H3IirW f82Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=0S7HOs8dIFvnB5cybVXZwAHkW2prHPtWKJV/l+kKrEQ=; b=CJvUhND/jPFhF6/AOFTB+kBcnoQThGfPCpEBQACQUYyFMDU/7shdc1GbSfVJ4gh/81 dhlqb9x5FaXe/iJ0Ue2VyGfr6D8tPz8TyF5PJM/r+C1ulhXUiauSHuzm6YvcBAIqoF9L VXA1LIrxcQUfojzttxFai7lNkpd9B07hslNnVEh2nmDTVI6b34evWb0fvU6jGXpj1Awp eH+2gFjlqpQLuuaopq1D5cmoxJPOqMgVTcuNA4Te4NlHWDH4Y0SLXnnzpRjvZaeUZDG1 OQK7b5icR4EyRq5N9L2K/UqYTqJ+hUT1uFz50iIKRaXCpG04cDNAaufhS4BpInSU5SK3 BH+Q== X-Gm-Message-State: AODbwcBgME5rYUB3O645mb69fCqIQEmWDzl4NBoS3if9ION6sjkeHgSe bet9l2aE6uf5DcEfrfTbXUaWXM0AQw== X-Received: by 10.176.92.103 with SMTP id a39mr7119141uag.130.1494955286936; Tue, 16 May 2017 10:21:26 -0700 (PDT) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Sender: zmedico@gmail.com Received: by 10.176.4.199 with HTTP; Tue, 16 May 2017 10:21:26 -0700 (PDT) In-Reply-To: <1494955143.1591.3.camel@gentoo.org> References: <20170502214840.10124-1-zmedico@gentoo.org> <1494955143.1591.3.camel@gentoo.org> From: Zac Medico Date: Tue, 16 May 2017 10:21:26 -0700 X-Google-Sender-Auth: FRGjxDDixDWruflUR8Tq8f7qPdE Message-ID: Subject: Re: [gentoo-dev] [PATCH] python-utils-r1.eclass: support PYTHON_IMPLS_NO_STRICT variable To: =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= Cc: gentoo-dev@lists.gentoo.org, python@gentoo.org Content-Type: multipart/alternative; boundary="f403043eebd0d54492054fa766af" X-Archives-Salt: ea41bddf-c660-42e5-b112-21c7b42dc215 X-Archives-Hash: 70748ab6602cdde8ed2778bec7388570 --f403043eebd0d54492054fa766af Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, May 16, 2017 at 10:19 AM, Micha=C5=82 G=C3=B3rny wrote: > On wto, 2017-05-02 at 14:48 -0700, Zac Medico wrote: > > This is intended to be set by the user when using ebuilds that may > > have unknown implementations in PYTHON_COMPAT. The assumption is > > that the ebuilds are intended to be used within multiple contexts > > which can involve revisions of this eclass that support different > > python implementations. > > --- > > eclass/python-utils-r1.eclass | 16 ++++++++++++++++ > > 1 file changed, 16 insertions(+) > > > > diff --git a/eclass/python-utils-r1.eclass b/eclass/python-utils-r1. > eclass > > index 66a359e..1846da3 100644 > > --- a/eclass/python-utils-r1.eclass > > +++ b/eclass/python-utils-r1.eclass > > @@ -47,6 +47,21 @@ _PYTHON_ALL_IMPLS=3D( > > ) > > readonly _PYTHON_ALL_IMPLS > > > > +# @ECLASS-VARIABLE: PYTHON_IMPLS_NO_STRICT > > +# @DESCRIPTION: > > +# Tolerate unknown implementations in PYTHON_COMPAT. > > +# > > +# This is intended to be set by the user when using ebuilds that may > > +# have unknown implementations in PYTHON_COMPAT. The assumption is > > +# that the ebuilds are intended to be used within multiple contexts > > +# which can involve revisions of this eclass that support different > > +# python implementations. > > +# > > +# Example: > > +# @CODE > > +# PYTHON_IMPLS_NO_STRICT=3D1 > > +# @CODE > > + > > # @FUNCTION: _python_impl_supported > > # @USAGE: > > # @INTERNAL > > @@ -79,6 +94,7 @@ _python_impl_supported() { > > fi > > ;; > > *) > > + [[ -n ${PYTHON_IMPLS_NO_STRICT} ]] && return 1 > > die "Invalid implementation in PYTHON_COMPAT: > ${impl}" > > esac > > } > > I've changed the name to PYTHON_COMPAT_NO_STRICT to fit the eclasses > better, and marked it @INTERNAL. Otherwise, committed now. Okay, thanks! --=20 Thanks, Zac --f403043eebd0d54492054fa766af Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On T= ue, May 16, 2017 at 10:19 AM, Micha=C5=82 G=C3=B3rny <= mgorny@gentoo.org> wrote:
On wto, 2017-05-02 at 14:48 -0700, Zac Medico wrote:
> This is intended to be set by the user when using ebuilds that may
> have unknown implementations in PYTHON_COMPAT. The assumption is
> that the ebuilds are intended to be used within multiple contexts
> which can involve revisions of this eclass that support different
> python implementations.
> ---
>=C2=A0 eclass/python-utils-r1.eclass | 16 ++++++++++++++++
>=C2=A0 1 file changed, 16 insertions(+)
>
> diff --git a/eclass/python-utils-r1.eclass b/eclass/python-utils-= r1.eclass
> index 66a359e..1846da3 100644
> --- a/eclass/python-utils-r1.eclass
> +++ b/eclass/python-utils-r1.eclass
> @@ -47,6 +47,21 @@ _PYTHON_ALL_IMPLS=3D(
>=C2=A0 )
>=C2=A0 readonly _PYTHON_ALL_IMPLS
>
> +# @ECLASS-VARIABLE: PYTHON_IMPLS_NO_STRICT
> +# @DESCRIPTION:
> +# Tolerate unknown implementations in PYTHON_COMPAT.
> +#
> +# This is intended to be set by the user when using ebuilds that may<= br> > +# have unknown implementations in PYTHON_COMPAT. The assumption is > +# that the ebuilds are intended to be used within multiple contexts > +# which can involve revisions of this eclass that support different > +# python implementations.
> +#
> +# Example:
> +# @CODE
> +# PYTHON_IMPLS_NO_STRICT=3D1
> +# @CODE
> +
>=C2=A0 # @FUNCTION: _python_impl_supported
>=C2=A0 # @USAGE: <impl>
>=C2=A0 # @INTERNAL
> @@ -79,6 +94,7 @@ _python_impl_supported() {
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0fi
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0;;
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0*)
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0[[ -n ${PYTHON_IMPLS_NO_STRICT} ]] && return 1
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0die "Invalid implementation in PYTHON_COMPAT: ${impl}&quo= t;
>=C2=A0 =C2=A0 =C2=A0 =C2=A0esac
>=C2=A0 }

I've changed the name to PYTHON_COMPAT_NO_STRICT to fit the= eclasses
better, and marked it @INTERNAL. Otherwise, committed now.

Okay, thanks!
--
Thanks,
Zac
--f403043eebd0d54492054fa766af--