public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Zac Medico <zmedico@gentoo.org>
To: "Michał Górny" <mgorny@gentoo.org>
Cc: gentoo-dev@lists.gentoo.org, python@gentoo.org
Subject: Re: [gentoo-dev] [PATCH] python-utils-r1.eclass: support PYTHON_IMPLS_NO_STRICT variable
Date: Tue, 16 May 2017 10:21:26 -0700	[thread overview]
Message-ID: <CAMiTYSokje0dYpXYPOCET5CYaS2QVaZJeT0awy19wJCfacDnJA@mail.gmail.com> (raw)
In-Reply-To: <1494955143.1591.3.camel@gentoo.org>

[-- Attachment #1: Type: text/plain, Size: 1982 bytes --]

On Tue, May 16, 2017 at 10:19 AM, Michał Górny <mgorny@gentoo.org> wrote:

> On wto, 2017-05-02 at 14:48 -0700, Zac Medico wrote:
> > This is intended to be set by the user when using ebuilds that may
> > have unknown implementations in PYTHON_COMPAT. The assumption is
> > that the ebuilds are intended to be used within multiple contexts
> > which can involve revisions of this eclass that support different
> > python implementations.
> > ---
> >  eclass/python-utils-r1.eclass | 16 ++++++++++++++++
> >  1 file changed, 16 insertions(+)
> >
> > diff --git a/eclass/python-utils-r1.eclass b/eclass/python-utils-r1.
> eclass
> > index 66a359e..1846da3 100644
> > --- a/eclass/python-utils-r1.eclass
> > +++ b/eclass/python-utils-r1.eclass
> > @@ -47,6 +47,21 @@ _PYTHON_ALL_IMPLS=(
> >  )
> >  readonly _PYTHON_ALL_IMPLS
> >
> > +# @ECLASS-VARIABLE: PYTHON_IMPLS_NO_STRICT
> > +# @DESCRIPTION:
> > +# Tolerate unknown implementations in PYTHON_COMPAT.
> > +#
> > +# This is intended to be set by the user when using ebuilds that may
> > +# have unknown implementations in PYTHON_COMPAT. The assumption is
> > +# that the ebuilds are intended to be used within multiple contexts
> > +# which can involve revisions of this eclass that support different
> > +# python implementations.
> > +#
> > +# Example:
> > +# @CODE
> > +# PYTHON_IMPLS_NO_STRICT=1
> > +# @CODE
> > +
> >  # @FUNCTION: _python_impl_supported
> >  # @USAGE: <impl>
> >  # @INTERNAL
> > @@ -79,6 +94,7 @@ _python_impl_supported() {
> >                       fi
> >                       ;;
> >               *)
> > +                     [[ -n ${PYTHON_IMPLS_NO_STRICT} ]] && return 1
> >                       die "Invalid implementation in PYTHON_COMPAT:
> ${impl}"
> >       esac
> >  }
>
> I've changed the name to PYTHON_COMPAT_NO_STRICT to fit the eclasses
> better, and marked it @INTERNAL. Otherwise, committed now.


Okay, thanks!
-- 
Thanks,
Zac

[-- Attachment #2: Type: text/html, Size: 2733 bytes --]

      reply	other threads:[~2017-05-16 17:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-02 21:48 [gentoo-dev] [PATCH] python-utils-r1.eclass: support PYTHON_IMPLS_NO_STRICT variable Zac Medico
2017-05-04 20:34 ` [gentoo-dev] " Zac Medico
2017-05-05  5:29   ` Michał Górny
2017-05-05  6:53     ` Zac Medico
2017-05-16 17:19 ` [gentoo-dev] " Michał Górny
2017-05-16 17:21   ` Zac Medico [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMiTYSokje0dYpXYPOCET5CYaS2QVaZJeT0awy19wJCfacDnJA@mail.gmail.com \
    --to=zmedico@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    --cc=mgorny@gentoo.org \
    --cc=python@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox