From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id AF30C138334 for ; Sat, 29 Sep 2018 13:25:45 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id E84E5E0978; Sat, 29 Sep 2018 13:25:41 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 8633FE0969 for ; Sat, 29 Sep 2018 13:25:41 +0000 (UTC) Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: djc) by smtp.gentoo.org (Postfix) with ESMTPSA id 61E86335C58 for ; Sat, 29 Sep 2018 13:25:40 +0000 (UTC) Received: by mail-wm1-f51.google.com with SMTP id y3-v6so3684351wma.1 for ; Sat, 29 Sep 2018 06:25:40 -0700 (PDT) X-Gm-Message-State: ABuFfoh6O0GPTIHtWDAepyOak43qCTEq2Xz6VcyKo+QKu0kl6vPmFiVX H4xydzptfgTQneLwAGV5gHkAvpX8uybwU28mK5I= X-Google-Smtp-Source: ACcGV60RzWY92EnZOleN2pBpwx00KX/Va0i5qAsie6Pr1mtsoNOTCk0KpMOAb+t7/vMSiw4rqETz0Ld+26xw8wBmz/c= X-Received: by 2002:a1c:1745:: with SMTP id 66-v6mr4529454wmx.38.1538227537417; Sat, 29 Sep 2018 06:25:37 -0700 (PDT) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 References: <1538209150.1199.7.camel@gentoo.org> <20180929151415.337aa5b3@wim.jer> In-Reply-To: <20180929151415.337aa5b3@wim.jer> From: Dirkjan Ochtman Date: Sat, 29 Sep 2018 15:25:25 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [gentoo-dev] Signed-off-by verification incoming To: Gentoo Development Content-Type: multipart/alternative; boundary="000000000000f39fa5057702814b" X-Archives-Salt: 11e97639-7449-4d4c-94ec-38ff6ee6c17a X-Archives-Hash: 1551538e9230e29c5c004d3d93f76a9b --000000000000f39fa5057702814b Content-Type: text/plain; charset="UTF-8" On Sat, Sep 29, 2018 at 3:14 PM Jeroen Roovers wrote: > 0a) Explain to me how to fix my commits that I now can't push, or > 0b) disable that hook immediately. > Try git rebase -i and use "r" for "reword" on every commit. > 1) Update repoman to enforce it _before_ the commit is executed. > Some kind of repoman support would make this much easier to handle. As it is, doing this by hand for the trivial case (only my own changes) is a PITA. repoman could grow some kind of --sign-off option that appends this to the commit message presumably? I think repoman checks happen on the tree, not on the commit, so I'm not sure how you think enforcing it before the commit makes sense (the line is effectively part of the commit). > 2) Wait for the repoman update to trickle down to all developers. > 3) Announce it ahead of time. > Some more lead time would be appreciated, yes. Regards, Dirkjan --000000000000f39fa5057702814b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Sat, Sep 29, 2018 at 3:14 PM Jeroen Roovers <jer@gentoo.org> wrote:
0a) Explain to me how to fix my = commits that I now can't push, or
0b) disable that hook immediately.

Try = git rebase -i and use "r" for "reword" on every commit.=
=C2=A0
1) Update repoman to enforce it _before_ the commit is executed.

Some kind of repoman support would make this much= easier to handle. As it is, doing this by hand for the trivial case (only = my own changes) is a PITA. repoman could grow some kind of --sign-off optio= n that appends this to the commit message presumably?

<= div>I think repoman checks happen on the tree, not on the commit, so I'= m not sure how you think enforcing it before the commit makes sense (the li= ne is effectively part of the commit).
=C2=A0
2) Wait for the repoman update to trickle down to all developers.
3) Announce it ahead of time.

Some more= lead time would be appreciated, yes.

Regards,

Dirkjan
=C2=A0
--000000000000f39fa5057702814b--