From mboxrd@z Thu Jan 1 00:00:00 1970
Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org)
by finch.gentoo.org with esmtp (Exim 4.60)
(envelope-from <gentoo-dev+bounces-48355-garchives=archives.gentoo.org@lists.gentoo.org>)
id 1RIa24-000265-W3
for garchives@archives.gentoo.org; Tue, 25 Oct 2011 05:58:41 +0000
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
by pigeon.gentoo.org (Postfix) with SMTP id 6E96621C1BA;
Tue, 25 Oct 2011 05:58:22 +0000 (UTC)
Received: from mail-iy0-f181.google.com (mail-iy0-f181.google.com [209.85.210.181])
by pigeon.gentoo.org (Postfix) with ESMTP id 9C35B21C162
for <gentoo-dev@lists.gentoo.org>; Tue, 25 Oct 2011 05:57:31 +0000 (UTC)
Received: by iahk25 with SMTP id k25so238834iah.40
for <gentoo-dev@lists.gentoo.org>; Mon, 24 Oct 2011 22:57:31 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=gamma;
h=mime-version:sender:in-reply-to:references:from:date
:x-google-sender-auth:message-id:subject:to:content-type
:content-transfer-encoding;
bh=ALhBODEAsqoaeZn7eTnx3GQ7A/8o2Jn2t8OSd4y6pHs=;
b=NLofWMoxYMfusTMe97bREvCGWFo15fsrrM7ZP8T+yd07rE+QYRoaREXcKZins0OqZt
I/rpVEa3/ytMZEoAz6D3AhM5TysDHylwAp2onTgVHByWRp9875nKoqwDaqECWsyRa609
upZRFSdDxVscfl5DLlv/ppBk5zh3XRGKLkpyg=
Received: by 10.43.52.136 with SMTP id vm8mr43543011icb.26.1319522251033; Mon,
24 Oct 2011 22:57:31 -0700 (PDT)
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
MIME-Version: 1.0
Sender: vapierfilter@gmail.com
Received: by 10.50.203.74 with HTTP; Mon, 24 Oct 2011 22:57:11 -0700 (PDT)
In-Reply-To: <20111024094654.3699c247@pomiocik.lan>
References: <1319394037-4619-1-git-send-email-mgorny@gentoo.org>
<20111024034223.GX22488@ohnopublishing.net> <20111024094654.3699c247@pomiocik.lan>
From: Mike Frysinger <vapier@gentoo.org>
Date: Tue, 25 Oct 2011 01:57:11 -0400
X-Google-Sender-Auth: sQ7It-0snEnQtum_GGYiIhaMVVU
Message-ID: <CAJaTeToh3WVAsLV8Zn7_fy0JZnOdYnw8opM+cXBpNxy46nbDeA@mail.gmail.com>
Subject: Re: [gentoo-dev] [PATCH scons-utils] Support setting common SCons
arguments using myesconsargs.
To: gentoo-dev@lists.gentoo.org
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-Archives-Salt:
X-Archives-Hash: a2fe61df2d77e9791d08d140b138132c
On Mon, Oct 24, 2011 at 03:46, Micha=C5=82 G=C3=B3rny wrote:
> On Mon, 24 Oct 2011 03:42:24 +0000 Nathan Phillip Brink wrote:
>> On Sun, Oct 23, 2011 at 08:20:37PM +0200, Micha?? G??rny wrote:
>> > ---
>> > =C2=A0scons-utils.eclass | =C2=A0 33 +++++++++++++++++++++++++--------
>> > =C2=A01 files changed, 25 insertions(+), 8 deletions(-)
>> ...
>> > +# @ECLASS-VARIABLE: myesconsargs
>> > +# @DEFAULT_UNSET
>> > +# @DESCRIPTION:
>> > +# List of package-specific options to pass to all SCons calls.
>> > Supposed to be +# set in src_configure().
>>
>> Shouldn't this variable be named MYESCONSARGS since it is being
>> introduced into the global scope?
>
> I can't deny that but I'd like to keep it consistent with cmake-utils
> and autotools-utils. Alternate approach would be to make it local to
> src_configure() and add scons-utils_src_configure() which would export
> it under internal name but I don't think that's really worth the effort.
sounds like you want @VARIABLE and not @ECLASS-VARIABLE
-mike