From: Mike Frysinger <vapier@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH scons-utils] Support setting common SCons arguments using myesconsargs.
Date: Tue, 25 Oct 2011 01:57:11 -0400 [thread overview]
Message-ID: <CAJaTeToh3WVAsLV8Zn7_fy0JZnOdYnw8opM+cXBpNxy46nbDeA@mail.gmail.com> (raw)
In-Reply-To: <20111024094654.3699c247@pomiocik.lan>
On Mon, Oct 24, 2011 at 03:46, Michał Górny wrote:
> On Mon, 24 Oct 2011 03:42:24 +0000 Nathan Phillip Brink wrote:
>> On Sun, Oct 23, 2011 at 08:20:37PM +0200, Micha?? G??rny wrote:
>> > ---
>> > scons-utils.eclass | 33 +++++++++++++++++++++++++--------
>> > 1 files changed, 25 insertions(+), 8 deletions(-)
>> ...
>> > +# @ECLASS-VARIABLE: myesconsargs
>> > +# @DEFAULT_UNSET
>> > +# @DESCRIPTION:
>> > +# List of package-specific options to pass to all SCons calls.
>> > Supposed to be +# set in src_configure().
>>
>> Shouldn't this variable be named MYESCONSARGS since it is being
>> introduced into the global scope?
>
> I can't deny that but I'd like to keep it consistent with cmake-utils
> and autotools-utils. Alternate approach would be to make it local to
> src_configure() and add scons-utils_src_configure() which would export
> it under internal name but I don't think that's really worth the effort.
sounds like you want @VARIABLE and not @ECLASS-VARIABLE
-mike
next prev parent reply other threads:[~2011-10-25 5:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-23 18:20 [gentoo-dev] [PATCH scons-utils] Support setting common SCons arguments using myesconsargs Michał Górny
2011-10-24 3:42 ` Nathan Phillip Brink
2011-10-24 7:46 ` Michał Górny
2011-10-25 5:57 ` Mike Frysinger [this message]
2011-10-25 16:37 ` Michał Górny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJaTeToh3WVAsLV8Zn7_fy0JZnOdYnw8opM+cXBpNxy46nbDeA@mail.gmail.com \
--to=vapier@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox