From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 8CB76138010 for ; Thu, 13 Sep 2012 06:31:24 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 371B221C02D; Thu, 13 Sep 2012 06:31:15 +0000 (UTC) Received: from mail-vb0-f53.google.com (mail-vb0-f53.google.com [209.85.212.53]) by pigeon.gentoo.org (Postfix) with ESMTP id 320DFE057F for ; Thu, 13 Sep 2012 06:30:19 +0000 (UTC) Received: by vbbfc21 with SMTP id fc21so3135030vbb.40 for ; Wed, 12 Sep 2012 23:30:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:content-type; bh=DopR8wQsSFSPyCRck0HUUE7zYvrWQWGKaVom08AQIoE=; b=tnDJ4bQUX6tw7Oo02SPKoHaPvejjy2Kre/SBAI+EEcc5TLo0YCL3z7GKEjBraSS658 /MZLP1uHGWVQr+zoy1+YyfBaxWqmw8GZsC4KEkwuih4QYs4KMxOi4wdmQu34k2/v9JRi 32YFvBnWu4SdbJheUspQPq4kFnp79oIwzAHX2HTctBpiG11XjHTn2SReAxpXJ8bceiY1 9Kawe6p9IBEUAUlbN1KgoTBVMBle2sPlh8oPaRpdNTKY0kGSMX2Rw85thYAy0HK/hTz7 rFLl5o0NDlVnNNtdIfpB4TBgRw4ctWrOSuWHbp8d+p3FUg+9LuHMfQ09LZUEH1JMJHVM yIsA== Received: by 10.52.27.239 with SMTP id w15mr490010vdg.96.1347517819614; Wed, 12 Sep 2012 23:30:19 -0700 (PDT) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Sender: vapierfilter@gmail.com Received: by 10.58.164.66 with HTTP; Wed, 12 Sep 2012 23:29:59 -0700 (PDT) In-Reply-To: <20561.31658.907933.499615@a1i15.kph.uni-mainz.de> References: <20120912203621.GA28593@localhost> <20561.29622.649540.849023@a1i15.kph.uni-mainz.de> <20561.31658.907933.499615@a1i15.kph.uni-mainz.de> From: Mike Frysinger Date: Thu, 13 Sep 2012 02:29:59 -0400 X-Google-Sender-Auth: ORwgEbDaXSNchBAsisKlER26b1g Message-ID: Subject: Re: [gentoo-dev] EAPI5: require ebuilds/eclasses to not use any vars/funcs prefixed with __ To: gentoo-dev@lists.gentoo.org Content-Type: text/plain; charset=ISO-8859-1 X-Archives-Salt: 2b771586-32fb-44f7-bb7f-063e90eb184a X-Archives-Hash: a373fdd5b408490641703d4345f4748f On Thu, Sep 13, 2012 at 2:22 AM, Ulrich Mueller wrote: >>>>>> On Thu, 13 Sep 2012, Mike Frysinger wrote: >>> Maybe it's better to add a --{save,restore} option pair: >>> >>> addwrite --save /foo/bar >>> # some commands writing to /foo/bar here >>> addwrite --restore # restore last saved state >>> >>> or --{push,pop} to allow for nested calls, but maybe that would be >>> overkill. > >> not sure how your --save/--restore isn't a --push/--pop already > > --save/--restore would keep one saved state (which would be > overwritten with the next --save), whereas --push/--pop would maintain > a stack. that wouldn't really be any different than if you implement the -r option like so: - `addwrite /foo` would always append the path regardless of existence already in the variable - `addwrite -r /foo` would remove exactly 1 occurence so if you don't want to do push/pop, let's stick with just adding a -r flag and implementing things as described above as it makes dev's lives simpler. -mike