From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id A8518138334 for ; Fri, 20 Sep 2019 17:25:03 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id E4136E086A; Fri, 20 Sep 2019 17:24:59 +0000 (UTC) Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 8A8D5E083B for ; Fri, 20 Sep 2019 17:24:59 +0000 (UTC) Received: from mail-io1-f41.google.com (mail-io1-f41.google.com [209.85.166.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: floppym) by smtp.gentoo.org (Postfix) with ESMTPSA id 6567334B420 for ; Fri, 20 Sep 2019 17:24:58 +0000 (UTC) Received: by mail-io1-f41.google.com with SMTP id a1so17930706ioc.6 for ; Fri, 20 Sep 2019 10:24:58 -0700 (PDT) X-Gm-Message-State: APjAAAXcgX427o6oLLnXOw2DCLxg9u5e/i3mqBDOtwb0VA42OI5jrGGp 5SKTK3mJJyJN2XoR9YkHWpqui6aipieGYTdAyk0= X-Google-Smtp-Source: APXvYqxf9jWF8A4smfbXr2efUZa+tiGOirVwMn3Mu+uDQrCySNAs0obNSC6r9VpFD8UKJtKmc/L+z4aw9cWbrtCNyIU= X-Received: by 2002:a6b:6f02:: with SMTP id k2mr20110772ioc.30.1569000296241; Fri, 20 Sep 2019 10:24:56 -0700 (PDT) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 References: <5fc919ec85751bd88d4bf0775ba1733584f92dc2.camel@gentoo.org> <20e57b194284c4d20e6781573fd0387257aed9f1.camel@gentoo.org> In-Reply-To: <20e57b194284c4d20e6781573fd0387257aed9f1.camel@gentoo.org> From: Mike Gilbert Date: Fri, 20 Sep 2019 13:24:45 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [gentoo-dev] Underscores in USE flags To: Gentoo Dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Archives-Salt: f04c8b40-21ef-4580-a365-0c8ed43312ff X-Archives-Hash: a91ff417a2d736dcfdb05a864a8b0f08 On Fri, Sep 20, 2019 at 12:55 PM Micha=C5=82 G=C3=B3rny = wrote: > > On Fri, 2019-09-20 at 12:41 -0400, Mike Gilbert wrote: > > On Fri, Sep 20, 2019 at 12:11 PM Micha=C5=82 G=C3=B3rny wrote: > > > On Fri, 2019-09-20 at 11:46 -0400, Mike Gilbert wrote: > > > > Recently, a large number of bugs were filed against packages that h= ave > > > > USE flag names which contain underscores. Apparently PMS prohibits > > > > this except when the USE flag is part of a USE_EXPAND variable. > > > > > > > > https://projects.gentoo.org/pms/7/pms.html#x1-200003.1.4 > > > > > > > > I'm not certain when this text was added to PMS, or how many of the > > > > affected USE flags pre-date this policy. > > > > > > > > Portage seems to have no issue dealing with underscores, so this > > > > doesn't seem to be solving any technical problem. > > > > > > > > I am pretty sure that renaming a bunch of USE flags will cause some > > > > amount of end-user confusion, for very little benefit. Is enforcing > > > > this part of PMS really worth it? > > > > > > And having packages with pretended-USE_EXPAND-that-does-not-work-as- > > > USE_EXPAND is less confusing to the users? > > > > I doubt users immediately think "USE_EXPAND" when they see an underscor= e. > > > > Portage's seems fairly unambiguous to me. For example: > > > > % emerge -pv1O app-misc/foo > > > > These are the packages that would be merged, in order: > > > > [ebuild N ] app-misc/foo-0::local USE=3D"-modern_kernel" > > PYTHON_TARGETS=3D"python3_7" VIDEO_CARDS=3D"radeon" 0 KiB > > > > Total: 1 package (1 new), Size of downloads: 0 KiB > > > > I don't think anyone would mistake "modern_kernel" for a USE_EXPAND > > value given the above. > > > > Look at the humongous list of flags on dev-libs/aws-sdk-cpp. They all > start with 'aws_targets' which is a clear attempt to emulate USE_EXPAND. > Expect that they won't work as USE_EXPAND, user typing: > > AWS_TARGETS=3D"foo bar baz" > > will just wildly confused, and in the end this prefixing is just silly > and causes the flag names to become awfully long. Ok, so you chery-picked one particularly horrible example. The Portage output still puts them in USE=3D"" section, though the user probably won't see that given the massive USE flag list. My point still stands for many of the other packages in the repo that don't have several dozen flags.