From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 3C266158B20 for ; Wed, 05 Feb 2025 19:42:50 +0000 (UTC) Received: from lists.gentoo.org (bobolink.gentoo.org [140.211.166.189]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: relay-lists.gentoo.org@gentoo.org) by smtp.gentoo.org (Postfix) with ESMTPSA id 22D9F343095 for ; Wed, 05 Feb 2025 19:42:50 +0000 (UTC) Received: from bobolink.gentoo.org (localhost [127.0.0.1]) by bobolink.gentoo.org (Postfix) with ESMTP id D67C6110479; Wed, 05 Feb 2025 19:42:07 +0000 (UTC) Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by bobolink.gentoo.org (Postfix) with ESMTPS id 0F72B1103CB for ; Wed, 05 Feb 2025 19:42:07 +0000 (UTC) Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: floppym) by smtp.gentoo.org (Postfix) with ESMTPSA id B9C7C342F8C for ; Wed, 05 Feb 2025 19:42:06 +0000 (UTC) Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-aaf57c2e0beso36937666b.3 for ; Wed, 05 Feb 2025 11:42:06 -0800 (PST) X-Gm-Message-State: AOJu0Yx4gFAU4bsOOU8a7R6PD/GFb+V1z1MNS0JTaMA491/CWfGLMN9s 7VUxjJezaDb6kFUaMgQEr5haOm/RZ5mHT9t+X1hEt32CkFa9pRM/z1y3fWKP6SgTJLPNoLgxWpD 6OQ9UJ2NhXiZ+gqvAso8e2ju9C/o= X-Google-Smtp-Source: AGHT+IGfu7WgqSOl8n3ThAA3qkgydC/MQwc4tW84BBmnCiDgGF0GrtjQ0zHrq2/AKEPPgkdO8SmtYVpeeDTjl030ACY= X-Received: by 2002:a17:906:f5a0:b0:aa6:aa8e:c89c with SMTP id a640c23a62f3a-ab75e2f2042mr478624966b.39.1738784524068; Wed, 05 Feb 2025 11:42:04 -0800 (PST) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 References: <20250205181010.1968506-1-floppym@gentoo.org> In-Reply-To: From: Mike Gilbert Date: Wed, 5 Feb 2025 14:41:52 -0500 X-Gmail-Original-Message-ID: X-Gm-Features: AWEUYZm_JeWyjkAsf3abcFz_RXQv9ptdoS8IZUS5Su05JaK-iOlzJ91j62bxPKo Message-ID: Subject: Re: [gentoo-dev] [PATCH] toolchain-funcs.eclass: avoid using tc-getCPP in compiler checks To: gentoo-dev@lists.gentoo.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Archives-Salt: 864b166a-2c70-46ac-af98-577cc7b5d4cd X-Archives-Hash: 56e58d9085996efec581a3d6c080ef41 On Wed, Feb 5, 2025 at 2:06=E2=80=AFPM Ionen Wolkens wro= te: > > On Wed, Feb 05, 2025 at 01:10:10PM -0500, Mike Gilbert wrote: > > We usually want to invoke cc -E rather than cpp directly. We should not > > rely on the quirk of tc-getCPP defaulting to "cc -E" when CPP is unset. > > I think it's a good change, but just to note it could break things > that relied on CPP being what's used. Thanks for that reminder.