From: Mike Gilbert <floppym@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH] toolchain-funcs.eclass: avoid using tc-getCPP in compiler checks
Date: Wed, 5 Feb 2025 14:41:52 -0500 [thread overview]
Message-ID: <CAJ0EP43hTA1BG4N4-8nnfmyksqxATRR2=KbKhX22ar8Zv7vVxQ@mail.gmail.com> (raw)
In-Reply-To: <Z6O2vxQmf42xEfKL@eversor>
On Wed, Feb 5, 2025 at 2:06 PM Ionen Wolkens <ionen@gentoo.org> wrote:
>
> On Wed, Feb 05, 2025 at 01:10:10PM -0500, Mike Gilbert wrote:
> > We usually want to invoke cc -E rather than cpp directly. We should not
> > rely on the quirk of tc-getCPP defaulting to "cc -E" when CPP is unset.
>
> I think it's a good change, but just to note it could break things
> that relied on CPP being what's used.
Thanks for that reminder.
prev parent reply other threads:[~2025-02-05 19:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 18:10 [gentoo-dev] [PATCH] toolchain-funcs.eclass: avoid using tc-getCPP in compiler checks Mike Gilbert
2025-02-05 18:39 ` James Le Cuirot
2025-02-05 19:06 ` Ionen Wolkens
2025-02-05 19:41 ` Mike Gilbert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ0EP43hTA1BG4N4-8nnfmyksqxATRR2=KbKhX22ar8Zv7vVxQ@mail.gmail.com' \
--to=floppym@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox