From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 5BC09158042 for ; Thu, 17 Oct 2024 14:50:59 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 602F4E08FF; Thu, 17 Oct 2024 14:50:55 +0000 (UTC) Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 23003E08F6 for ; Thu, 17 Oct 2024 14:50:55 +0000 (UTC) Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-5c9404c0d50so1140619a12.3 for ; Thu, 17 Oct 2024 07:50:54 -0700 (PDT) X-Gm-Message-State: AOJu0YyturZsbo8DeTNRNzAoutU/kGhj0ZPOWFFZNZ1FX0rwGWVoUCi2 QiF0lV/lYyjXB77DiO0gS85J5C3emYFvKUikpGiWzg64v9VBeGzbsUqARfF6vLxQuqD4t3PbL/E Dwz85xBhq4pQlC95JkUKz9gwmO/I= X-Google-Smtp-Source: AGHT+IFocjUGJcV89iu4glY+dHMFU+M4tiPEP+vQz4+E4Vp2VAUUNf+4D1sSsuBz9+vpx4QM312VrDGawUvudn6tRFk= X-Received: by 2002:a05:6402:27c6:b0:5c9:1b50:1a5c with SMTP id 4fb4d7f45d1cf-5c9950b833dmr5763851a12.9.1729176651661; Thu, 17 Oct 2024 07:50:51 -0700 (PDT) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 References: <20241017055843.16396-1-ulm@gentoo.org> <20241017055843.16396-3-ulm@gentoo.org> In-Reply-To: <20241017055843.16396-3-ulm@gentoo.org> From: Mike Gilbert Date: Thu, 17 Oct 2024 10:50:40 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [gentoo-dev] [PATCH 3/4] cvs.eclass: New eclass variable ECVS_SSH_EXTRA_OPTS To: gentoo-dev@lists.gentoo.org Cc: =?UTF-8?Q?Ulrich_M=C3=BCller?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Archives-Salt: a0f95697-e179-4257-b23a-e6d8b5275371 X-Archives-Hash: ae22bf8be0ce00a0bce925ca49866a1f On Thu, Oct 17, 2024 at 1:58=E2=80=AFAM Ulrich M=C3=BCller = wrote: > > This allows passing additional options to ssh. > > Signed-off-by: Ulrich M=C3=BCller > --- > eclass/cvs.eclass | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/eclass/cvs.eclass b/eclass/cvs.eclass > index 1289ee54cc3b..5148daa2d57d 100644 > --- a/eclass/cvs.eclass > +++ b/eclass/cvs.eclass > @@ -174,6 +174,12 @@ _CVS_ECLASS=3D1 > # WARNING: If a SSH host key is not specified using this variable, the > # remote host key will not be verified. > > +# @ECLASS_VARIABLE: ECVS_SSH_EXTRA_OPTS > +# @DEFAULT_UNSET > +# @DESCRIPTION: > +# If SSH is used for "ext" authentication, this array variable can be > +# used to pass additional options to the SSH command. > + > # @ECLASS_VARIABLE: ECVS_CLEAN > # @DEFAULT_UNSET > # @DESCRIPTION: > @@ -387,6 +393,7 @@ cvs_fetch() { > -oUserKnownHostsFile=3D"${known_h= osts_file}" \\ > -oForwardX11=3Dno \\ > -oClearAllForwardings=3Dyes \\ > + ${ECVS_SSH_EXTRA_OPTS[*]} \\ Why use an array if you're going to collapse it using the "*" operator? Maybe use "${ECVS_SSH_EXTRA_OPTS[@]}" instead.