From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gentoo-dev+bounces-101843-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits))
	(No client certificate requested)
	by finch.gentoo.org (Postfix) with ESMTPS id 4423F1581D3
	for <garchives@archives.gentoo.org>; Wed, 22 May 2024 14:55:38 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id EC80EE2AC8;
	Wed, 22 May 2024 14:55:34 +0000 (UTC)
Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits))
	(No client certificate requested)
	by pigeon.gentoo.org (Postfix) with ESMTPS id 88EAFE2AC5
	for <gentoo-dev@lists.gentoo.org>; Wed, 22 May 2024 14:55:34 +0000 (UTC)
Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-572f6ee87c1so9885801a12.2
        for <gentoo-dev@lists.gentoo.org>; Wed, 22 May 2024 07:55:33 -0700 (PDT)
X-Gm-Message-State: AOJu0YzQbjZUYfR2qHo5opinWYXYJQdufU4DCf5zHjGJXCmrjlh00Gfw
	haJbhD/oeTTQkplQhbzR9SIEtDTvMZDQhGcyj3U5nADZlDJEZOEKiPTJfLG4edIbD0nTYiApPZM
	dP6hpx2DYNW7C1tIOz6/35gob1G0=
X-Google-Smtp-Source: AGHT+IGwTm10y2//auNqoRCscdv5Cs4wGRkoWKtbqFzxDyrE3t/hCOhfTcHAtvmT0g8NrY3YkeA0eCAS4RhFK9suTgk=
X-Received: by 2002:a50:d7db:0:b0:56e:2452:f867 with SMTP id
 4fb4d7f45d1cf-57832c64944mr1466690a12.37.1716389731133; Wed, 22 May 2024
 07:55:31 -0700 (PDT)
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
MIME-Version: 1.0
References: <20240522015830.1841810-1-floppym@gentoo.org> <20240522020519.1845786-1-floppym@gentoo.org>
 <u1q5u75p0@gentoo.org>
In-Reply-To: <u1q5u75p0@gentoo.org>
From: Mike Gilbert <floppym@gentoo.org>
Date: Wed, 22 May 2024 10:55:19 -0400
X-Gmail-Original-Message-ID: <CAJ0EP43SYAo2VmR0CLBjp7YEQLvPKkePRD5ZJrX++4zPV3_4_A@mail.gmail.com>
Message-ID: <CAJ0EP43SYAo2VmR0CLBjp7YEQLvPKkePRD5ZJrX++4zPV3_4_A@mail.gmail.com>
Subject: Re: [gentoo-dev] [PATCH v2] verify-sig.eclass: avoid calling unpack
 on sig files
To: gentoo-dev@lists.gentoo.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Archives-Salt: 1b9fadf8-4048-4810-9149-4bd0fee48dc1
X-Archives-Hash: b59e314e3edc05f62260082601faff2e

On Wed, May 22, 2024 at 1:53=E2=80=AFAM Ulrich Mueller <ulm@gentoo.org> wro=
te:
> Please provide an explanation what problem this patch fixes.
>
> Why is calling unpack on sig files bad? It should silently skip files
> with unknown extensions.

The main reason is that Portage does not *silently* skip unknown
extensions in unpack. For  example:

>>> Unpacking freerdp-2.11.7.tar.gz.asc to /x/portage/net-misc/freerdp-2.11=
.7/work
unpack freerdp-2.11.7.tar.gz.asc: file format not recognized. Ignoring.

The other reason would be the small/trivial efficiency gain; there is
no point in calling unpack on a file it won't be able to process.