From: Mike Gilbert <floppym@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH v2] verify-sig.eclass: avoid calling unpack on sig files
Date: Wed, 22 May 2024 10:55:19 -0400 [thread overview]
Message-ID: <CAJ0EP43SYAo2VmR0CLBjp7YEQLvPKkePRD5ZJrX++4zPV3_4_A@mail.gmail.com> (raw)
In-Reply-To: <u1q5u75p0@gentoo.org>
On Wed, May 22, 2024 at 1:53 AM Ulrich Mueller <ulm@gentoo.org> wrote:
> Please provide an explanation what problem this patch fixes.
>
> Why is calling unpack on sig files bad? It should silently skip files
> with unknown extensions.
The main reason is that Portage does not *silently* skip unknown
extensions in unpack. For example:
>>> Unpacking freerdp-2.11.7.tar.gz.asc to /x/portage/net-misc/freerdp-2.11.7/work
unpack freerdp-2.11.7.tar.gz.asc: file format not recognized. Ignoring.
The other reason would be the small/trivial efficiency gain; there is
no point in calling unpack on a file it won't be able to process.
prev parent reply other threads:[~2024-05-22 14:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-22 1:58 [gentoo-dev] [PATCH] verify-sig.eclass: avoid calling unpack on sig files Mike Gilbert
2024-05-22 2:05 ` [gentoo-dev] [PATCH v2] " Mike Gilbert
2024-05-22 3:38 ` Michał Górny
2024-05-22 14:59 ` Mike Gilbert
2024-05-22 5:53 ` Ulrich Mueller
2024-05-22 14:55 ` Mike Gilbert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJ0EP43SYAo2VmR0CLBjp7YEQLvPKkePRD5ZJrX++4zPV3_4_A@mail.gmail.com \
--to=floppym@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox