[gentoo-dev] [PATCH 1/2] linux-mod.eclass: drop unnecessary IUSE="kernel_linux"

[gentoo-dev] [PATCH 1/2] linux-mod.eclass: drop unnecessary IUSE="kernel_linux"

[Sam James]

It's already an implicit IUSE, so we don't need this.

Signed-off-by: Sam James <sam@gentoo.org>
---
 eclass/linux-mod.eclass | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/eclass/linux-mod.eclass b/eclass/linux-mod.eclass
index 9f4ae64f6b55..496b9c98b526 100644
--- a/eclass/linux-mod.eclass
+++ b/eclass/linux-mod.eclass
@@ -1,4 +1,4 @@
-# Copyright 1999-2021 Gentoo Authors
+# Copyright 1999-2022 Gentoo Authors
 # Distributed under the terms of the GNU General Public License v2
 
 # @ECLASS: linux-mod.eclass
@@ -170,7 +170,7 @@ esac
 	0) die "EAPI=${EAPI} is not supported with MODULES_OPTIONAL_USE_IUSE_DEFAULT due to lack of IUSE defaults" ;;
 esac
 
-IUSE="kernel_linux dist-kernel
+IUSE="dist-kernel
 	${MODULES_OPTIONAL_USE:+${_modules_optional_use_iuse_default}}${MODULES_OPTIONAL_USE}"
 SLOT="0"
 RDEPEND="
-- 
2.34.1

[gentoo-dev] [PATCH 2/2] linux-info.eclass: drop unnecessary IUSE="kernel_linux"

[Sam James]

It's already an implicit IUSE, so we don't need this.

Signed-off-by: Sam James <sam@gentoo.org>
---
 eclass/linux-info.eclass | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/eclass/linux-info.eclass b/eclass/linux-info.eclass
index 568f7a1a2832..a0942f0e554c 100644
--- a/eclass/linux-info.eclass
+++ b/eclass/linux-info.eclass
@@ -1,4 +1,4 @@
-# Copyright 1999-2021 Gentoo Authors
+# Copyright 1999-2022 Gentoo Authors
 # Distributed under the terms of the GNU General Public License v2
 
 # @ECLASS: linux-info.eclass
@@ -137,8 +137,6 @@ inherit toolchain-funcs
 
 EXPORT_FUNCTIONS pkg_setup
 
-IUSE="kernel_linux"
-
 # Bug fixes
 # fix to bug #75034
 case ${ARCH} in
-- 
2.34.1

Re: [gentoo-dev] [PATCH 2/2] linux-info.eclass: drop unnecessary IUSE="kernel_linux"

[Brian Evans]

[-- Attachment #1.1: Type: text/plain, Size: 564 bytes --]

On 1/4/2022 5:23 AM, Sam James wrote:
> It's already an implicit IUSE, so we don't need this.
> 
> Signed-off-by: Sam James <sam@gentoo.org>
> ---

This seems a bit excessive for something that will not change the end 
compilations in any way.

This one could just stay and not hurt anything.

The commits by soap on the same topic of kernel_* and elibc_* could have 
been done differently and eased into.

I really disagree with this move which just forces recompilation on 
@world update to dozens of packages in an install for no gain.

Brian

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

Re: [gentoo-dev] [PATCH 1/2] linux-mod.eclass: drop unnecessary IUSE="kernel_linux"

[Mike Gilbert]

On Tue, Jan 4, 2022 at 5:23 AM Sam James <sam@gentoo.org> wrote:
>
> It's already an implicit IUSE, so we don't need this.

I think it is better to declare it explicitly rather than relying on
the IUSE_IMPLICIT setting in profiles.

Re: [gentoo-dev] [PATCH 1/2] linux-mod.eclass: drop unnecessary IUSE="kernel_linux"

[Michał Górny]

On Tue, 2022-01-04 at 11:17 -0500, Mike Gilbert wrote:
> On Tue, Jan 4, 2022 at 5:23 AM Sam James <sam@gentoo.org> wrote:
> > 
> > It's already an implicit IUSE, so we don't need this.
> 
> I think it is better to declare it explicitly rather than relying on
> the IUSE_IMPLICIT setting in profiles.

I agree.  Perhaps we should go even further and remove them from
implicit flags.

-- 
Best regards,
Michał Górny

Re: [gentoo-dev] [PATCH 1/2] linux-mod.eclass: drop unnecessary IUSE="kernel_linux"

[Sam James]

[-- Attachment #1: Type: text/plain, Size: 1150 bytes --]



> On 4 Jan 2022, at 21:54, Michał Górny <mgorny@gentoo.org> wrote:
> 
> On Tue, 2022-01-04 at 11:17 -0500, Mike Gilbert wrote:
>> On Tue, Jan 4, 2022 at 5:23 AM Sam James <sam@gentoo.org> wrote:
>>> 
>>> It's already an implicit IUSE, so we don't need this.
>> 
>> I think it is better to declare it explicitly rather than relying on
>> the IUSE_IMPLICIT setting in profiles.
> 
> I agree.  Perhaps we should go even further and remove them from
> implicit flags.
> 

(Note: I did push this change already to coalesce this
with FreeBSD and other removals.)

I don't think declaring it explicitly is helpful given
in most cases (and even more now after recent
cleanups), it's relied upon without declaring it anyway.

Use within IUSE while it's implicit also means
IUSE seems to regularly get out of sync with
actual use within the ebuilds.

As for removing implicit use entirely: while you might
argue this could be okay for the Linux kernel, it would cause
unnecessary rebuilds indefinitely whenever we add a new dep
to an ebuild for e.g. Darwin, or if we did it for libcs,
for say, musl/non-glibc.

best,
sam

[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 618 bytes --]