From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org)
	by finch.gentoo.org with esmtp (Exim 4.60)
	(envelope-from <gentoo-dev+bounces-51779-garchives=archives.gentoo.org@lists.gentoo.org>)
	id 1SWTp0-0005dA-OW
	for garchives@archives.gentoo.org; Mon, 21 May 2012 14:42:55 +0000
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id 74FBBE096A;
	Mon, 21 May 2012 14:42:39 +0000 (UTC)
Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183])
	by pigeon.gentoo.org (Postfix) with ESMTP id 18F36E07A0
	for <gentoo-dev@lists.gentoo.org>; Mon, 21 May 2012 14:41:46 +0000 (UTC)
Received: from mail-yw0-f53.google.com (mail-yw0-f53.google.com [209.85.213.53])
	(using TLSv1 with cipher RC4-MD5 (128/128 bits))
	(No client certificate requested)
	(Authenticated sender: floppym)
	by smtp.gentoo.org (Postfix) with ESMTPSA id 816FE1B401A
	for <gentoo-dev@lists.gentoo.org>; Mon, 21 May 2012 14:41:45 +0000 (UTC)
Received: by yhp26 with SMTP id 26so4865718yhp.40
        for <gentoo-dev@lists.gentoo.org>; Mon, 21 May 2012 07:41:43 -0700 (PDT)
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
MIME-Version: 1.0
Received: by 10.68.234.200 with SMTP id ug8mr21188910pbc.54.1337611303376;
 Mon, 21 May 2012 07:41:43 -0700 (PDT)
Received: by 10.142.178.10 with HTTP; Mon, 21 May 2012 07:41:43 -0700 (PDT)
In-Reply-To: <4FB9D305.3080809@gentoo.org>
References: <4FB97D1D.9070004@gentoo.org>
	<20120520193625.6c8b2959@gentoo.org>
	<4FB98309.7030900@gentoo.org>
	<4FB985E9.3030107@gentoo.org>
	<4FB9D305.3080809@gentoo.org>
Date: Mon, 21 May 2012 10:41:43 -0400
Message-ID: <CAJ0EP43F1cmOfBHcO==JNFv9A-XNnZ8Cpq9QXYQ0-VduygJang@mail.gmail.com>
Subject: Re: [gentoo-dev] Re: enhancement for doicon/newicon in eutils.eclass
From: Mike Gilbert <floppym@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Content-Type: text/plain; charset=UTF-8
X-Archives-Salt: 7d01e57a-9395-4f96-a6b9-b4205e9ce1ce
X-Archives-Hash: 33b098d4d6adb2dabb4b3b461d57aa59

On Mon, May 21, 2012 at 1:30 AM, hasufell <hasufell@gentoo.org> wrote:
> On 05/21/2012 02:01 AM, Jonathan Callen wrote:
>> On 05/20/2012 07:49 PM, hasufell wrote:
>>> On 05/21/2012 01:36 AM, Alexis Ballier wrote:
>>>> On Mon, 21 May 2012 01:24:13 +0200 hasufell
>>>> <hasufell@gentoo.org> wrote:
>>>>
>>>>> I want support for installing icons into the appropriate
>>>>> directories which are under /usr/share/icons/... and not
>>>>> just pixmaps.
>>>>>
>>>>> proposal attached + diff
>>>>>
>>>>> This should not break existing ebuilds. Tested a bit and
>>>>> open for review now.
>>>>
>>>> maybe i missed something but cant you just make doicon a
>>>> newicon wrapper and remove all that code duplication ?
>>>>
>>
>>> I don't see how. "doicon" supports installing multiple icons
>>> with one command, as well as directories. That does not work for
>>> "newicon".
>>
>>
>>
>> Normally, new* is a wrapper for do* that does something like:
>>
>> newfoo() { # argument checking omitted... cp -P "${1}" "${T}/${2}"
>> dofoo "${T}/${2}" }
>>
>>
>
> That does not use "newins" like the old function. Why would I want to
> change that?
>

An alternative would be to factor the common code into a third
function, and call that from doicon and newicon.