From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id B2EF4138334 for ; Mon, 1 Oct 2018 13:00:58 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 12FCAE09B0; Mon, 1 Oct 2018 13:00:55 +0000 (UTC) Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id B40F5E099B for ; Mon, 1 Oct 2018 13:00:54 +0000 (UTC) Received: from mail-io1-f41.google.com (mail-io1-f41.google.com [209.85.166.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: floppym) by smtp.gentoo.org (Postfix) with ESMTPSA id 923D0335DBD for ; Mon, 1 Oct 2018 13:00:52 +0000 (UTC) Received: by mail-io1-f41.google.com with SMTP id y10-v6so9270730ioa.10 for ; Mon, 01 Oct 2018 06:00:52 -0700 (PDT) X-Gm-Message-State: ABuFfohXkrGfhmuAc+pB7ahuTC4CtthGVlsCheHt7yCeZ+RZH4xEr3zz xKtGMViYmvfjpEbS7mdb4eF5KOWJFVfPgqXZWuA= X-Google-Smtp-Source: ACcGV62n+gVrDddLEwrU3nots6knuIAywIFIkRPe1crvElf8Ul40YcUO6MQdTkHsei/MuRRcM2FM/T5dgY3ZJggPgxY= X-Received: by 2002:a6b:d817:: with SMTP id y23-v6mr7340774iob.247.1538398850502; Mon, 01 Oct 2018 06:00:50 -0700 (PDT) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 References: <20180930225035.25434-1-floppym@gentoo.org> <20180930225035.25434-3-floppym@gentoo.org> <2e0b1447-d520-c4cc-61f6-7a1ad1761684@gentoo.org> <1538396835.9799.2.camel@gentoo.org> In-Reply-To: <1538396835.9799.2.camel@gentoo.org> From: Mike Gilbert Date: Mon, 1 Oct 2018 09:00:38 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: [gentoo-dev] Re: [PATCH 3/5] xdg.eclass: move deps to RDEPEND To: Gentoo Dev Cc: remi@gentoo.org, freedesktop-bugs@gentoo.org, Gilles Dartiguelongue Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Archives-Salt: b0153a4a-4686-472b-b220-b240e8158191 X-Archives-Hash: d86aeb9482c285a1969bae939a1fa0c3 On Mon, Oct 1, 2018 at 8:27 AM Gilles Dartiguelongue wrote= : > > Le lundi 01 octobre 2018 =C3=A0 07:40 +0200, R=C3=A9mi Cardona a =C3=A9cr= it : > > Le 01/10/2018 =C3=A0 00:50, Mike Gilbert a =C3=A9crit : > > > update-desktop-database and update-mime-database are called from > > > ROOT in > > > pkg functions, so the related dependenices belong in RDEPEND. > > > > > > Signed-off-by: Mike Gilbert > > > > As far as the eclass goes, this is correct. But AFAIR, this was > > needed > > because some packages look for those tools at build time. It was ages > > ago so maybe it no longer applies. > > > > R=C3=A9mi > > > > A lot of autotools based packages do explicitly search for it. I don't > think they fail if it is missing though but a tinderbox run would be > welcome. That's... interesting. I think it would make more sense for these packages to state this dependency explicitly instead of relying on the dep from the eclass. > The reason why it is in DEPEND though is that none of these tools are > required at runtime. They are needed at postinst and postrm stages > which afaik makes them DEPEND on EAPI previous to EAPI 7 and BDEPEND in > EAPI 7 if I'm not mistaken. This is incorrect; programs executed in pkg_postinst/pkg_postrm should be present in RDEPEND. Consider a binpkg installation, which would ignore DEPEND, but would still execute pkg_postinst. Another option: since xdg-utils.eclass functions will politely skip the updates if the tools are missing, we could just drop the dependency from xdg.eclass entirely and wait for the tools to get installed through some indirect means.