[gentoo-dev] Re: [PATCH 3/5] xdg.eclass: move deps to RDEPEND

[Mike Gilbert <floppym@gentoo.org>]

On Mon, Oct 1, 2018 at 8:27 AM Gilles Dartiguelongue <eva@gentoo.org> wrote:
>
> Le lundi 01 octobre 2018 à 07:40 +0200, Rémi Cardona a écrit :
> > Le 01/10/2018 à 00:50, Mike Gilbert a écrit :
> > > update-desktop-database and update-mime-database are called from
> > > ROOT in
> > > pkg functions, so the related dependenices belong in RDEPEND.
> > >
> > > Signed-off-by: Mike Gilbert <floppym@gentoo.org>
> >
> > As far as the eclass goes, this is correct. But AFAIR, this was
> > needed
> > because some packages look for those tools at build time. It was ages
> > ago so maybe it no longer applies.
> >
> > Rémi
> >
>
> A lot of autotools based packages do explicitly search for it. I don't
> think they fail if it is missing though but a tinderbox run would be
> welcome.

That's... interesting. I think it would make more sense for these
packages to state this dependency explicitly instead of relying on the
dep from the eclass.

> The reason why it is in DEPEND though is that none of these tools are
> required at runtime. They are needed at postinst and postrm stages
> which afaik makes them DEPEND on EAPI previous to EAPI 7 and BDEPEND in
> EAPI 7 if I'm not mistaken.

This is incorrect; programs executed in pkg_postinst/pkg_postrm should
be present in RDEPEND. Consider a binpkg installation, which would
ignore DEPEND, but would still execute pkg_postinst.

Another option: since xdg-utils.eclass functions will politely skip
the updates if the tools are missing, we could just drop the
dependency from xdg.eclass entirely and wait for the tools to get
installed through some indirect means.