From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 88C81158009 for ; Sun, 25 Jun 2023 15:44:32 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 34E18E08AC; Sun, 25 Jun 2023 15:44:29 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id E48B1E089F for ; Sun, 25 Jun 2023 15:44:28 +0000 (UTC) Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-5702116762fso26029967b3.3 for ; Sun, 25 Jun 2023 08:44:28 -0700 (PDT) X-Gm-Message-State: AC+VfDyeGUa3kz4QGv9DWBEYuI+w0a35TI6Wfb7VkrWiuQStc7rlVeKm Of/rnWq/UUCIb6ucgLflPCSF3WIlvmGLPX48UhQ= X-Google-Smtp-Source: ACHHUZ7WWoWLHFLyjD2KL+JWn+ty3uMmGKEmvROUrM750uaoIsg5l5wnVxllv4TDP2S3Uh3KGcI6EL2qxkpULgTkzG4= X-Received: by 2002:a81:d24b:0:b0:56d:495d:d3f6 with SMTP id m11-20020a81d24b000000b0056d495dd3f6mr32939236ywl.29.1687707866170; Sun, 25 Jun 2023 08:44:26 -0700 (PDT) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 References: <20230624170138.4118012-1-floppym@gentoo.org> <881fd15c-92cb-5c19-4692-9609be588b22@gentoo.org> In-Reply-To: <881fd15c-92cb-5c19-4692-9609be588b22@gentoo.org> From: Mike Gilbert Date: Sun, 25 Jun 2023 11:44:15 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [gentoo-dev] [PATCH] acct-user.eclass: improve error message when usermod fails To: gentoo-dev@lists.gentoo.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Archives-Salt: 0700de51-de81-4c31-9af7-aa601da345a1 X-Archives-Hash: 936fa291f0a007e326ed964003431f5c On Sun, Jun 25, 2023 at 6:54=E2=80=AFAM Florian Schmaus w= rote: > No strong opinion, but it is often a good idea to include the exit > status. For example: > > die "usermod failed (${status})" That's a really good idea. It could also be applied to the useradd/groupadd/groupmod commands.