From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id D47A5158020 for ; Tue, 29 Nov 2022 22:31:42 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 79307E092B; Tue, 29 Nov 2022 22:31:39 +0000 (UTC) Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 3FD9DE091A for ; Tue, 29 Nov 2022 22:31:39 +0000 (UTC) Received: by mail-yb1-f171.google.com with SMTP id o127so3865859yba.5 for ; Tue, 29 Nov 2022 14:31:38 -0800 (PST) X-Gm-Message-State: ANoB5plSa/c8M/YdRrZBqadsfe7bP78HhQ1fmpfd6O4jIFSbD29Ge8yI oe59SwNA27tG/K+cTNX67jIjK6DVEaAjSuq5AwI= X-Google-Smtp-Source: AA0mqf4SP/jRyB6aPTyP901Xt2VvYrglKAdVj+6CQy+4ZHy/ap9CcJN4RLObtZEi6IpxWauCQP3aFO+y2zy2gHidAmA= X-Received: by 2002:a25:4181:0:b0:6f9:8f1:4d02 with SMTP id o123-20020a254181000000b006f908f14d02mr4882224yba.118.1669761096626; Tue, 29 Nov 2022 14:31:36 -0800 (PST) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 References: <20221129185544.1957747-1-floppym@gentoo.org> <9d77f3c0be43dc38a30c1c8024db9c784529547d.camel@gentoo.org> In-Reply-To: <9d77f3c0be43dc38a30c1c8024db9c784529547d.camel@gentoo.org> From: Mike Gilbert Date: Tue, 29 Nov 2022 17:31:25 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [gentoo-dev] [PATCH] linux-info.eclass: getfilevar: pass 'need-compiler=' to make To: gentoo-dev@lists.gentoo.org Content-Type: text/plain; charset="UTF-8" X-Archives-Salt: 65cce077-84d0-4ece-9498-fef6ebd38ca6 X-Archives-Hash: 670f848d7ebebfc96e98795c3b5b304b On Tue, Nov 29, 2022 at 5:14 PM James Le Cuirot wrote: > > On Tue, 2022-11-29 at 13:55 -0500, Mike Gilbert wrote: > > This avoids some unnecessary Makefile logic and gives a nice speed up. > > > > Before the change, linux-info_pkg_setup takes 11 to 15 seconds on my > > AMD Phenom II. After, it takes 3 to 4 seconds. > > > > Signed-off-by: Mike Gilbert > > --- > > eclass/linux-info.eclass | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/eclass/linux-info.eclass b/eclass/linux-info.eclass > > index fc125b0d751..3e64cb9457a 100644 > > --- a/eclass/linux-info.eclass > > +++ b/eclass/linux-info.eclass > > @@ -238,7 +238,9 @@ getfilevar() { > > # Pass dot-config=0 to avoid the config check in kernels prior to 5.4. > > [[ ${EAPI:-0} == [0123] ]] && nonfatal() { "$@"; } > > echo -e "e:\\n\\t@echo \$(${1})\\ninclude ${basefname}" | \ > > - nonfatal emake -C "${basedname}" --no-print-directory M="${T}" dot-config=0 need-config= ${BUILD_FIXES} -s -f - 2>/dev/null > > + nonfatal emake -C "${basedname}" --no-print-directory M="${T}" \ > > + dot-config=0 need-config= need-compiler= \ > > + ${BUILD_FIXES} -s -f - 2>/dev/null > > > > ARCH=${myARCH} > > fi > > I'm confused. Breaking up the line makes it faster? The change is stated in the email subject.