From: Mike Gilbert <floppym@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Cc: James Le Cuirot <chewi@gentoo.org>
Subject: Re: [gentoo-dev] [PATCH 1/4] acct-group.eclass: Fix for when building in a rooted prefix (EROOT)
Date: Tue, 6 Dec 2022 18:54:37 -0500 [thread overview]
Message-ID: <CAJ0EP42CR_O8OK--PtpRjef+aO9ck6RWm5_R4Ab=dAm=pcoJfw@mail.gmail.com> (raw)
In-Reply-To: <20221206222414.13633-1-chewi@gentoo.org>
On Tue, Dec 6, 2022 at 5:24 PM James Le Cuirot <chewi@gentoo.org> wrote:
>
> Groups are largely irrelevant for prefix, but we still don't want the
> build to break.
>
> Signed-off-by: James Le Cuirot <chewi@gentoo.org>
> ---
> eclass/acct-group.eclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/eclass/acct-group.eclass b/eclass/acct-group.eclass
> index 590a2f20ed8e..ada5fe386693 100644
> --- a/eclass/acct-group.eclass
> +++ b/eclass/acct-group.eclass
> @@ -176,7 +176,7 @@ acct-group_pkg_preinst() {
> fi
>
> if [[ -n ${ROOT} ]]; then
You should probably change this to [[ -n ${EROOT} ]]. Same goes for
acct-user.eclass.
Also see bug 779181; I'm not sure updating ${EROOT}/etc/group and
${EROOT}/etc/passwd makes any sense at all.
next prev parent reply other threads:[~2022-12-06 23:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 22:24 [gentoo-dev] [PATCH 1/4] acct-group.eclass: Fix for when building in a rooted prefix (EROOT) James Le Cuirot
2022-12-06 22:24 ` [gentoo-dev] [PATCH 2/4] acct-user.eclass: " James Le Cuirot
2022-12-06 22:24 ` [gentoo-dev] [PATCH 3/4] user-info.eclass: " James Le Cuirot
2022-12-06 23:57 ` Mike Gilbert
2022-12-06 22:24 ` [gentoo-dev] [PATCH 4/4] user.eclass: " James Le Cuirot
2022-12-06 23:55 ` Mike Gilbert
2022-12-06 23:54 ` Mike Gilbert [this message]
2022-12-07 9:24 ` [gentoo-dev] [PATCH 1/4] acct-group.eclass: " James Le Cuirot
2022-12-07 16:52 ` Mike Gilbert
2022-12-07 17:19 ` Fabian Groffen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ0EP42CR_O8OK--PtpRjef+aO9ck6RWm5_R4Ab=dAm=pcoJfw@mail.gmail.com' \
--to=floppym@gentoo.org \
--cc=chewi@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox