From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 96A72138334 for ; Wed, 3 Oct 2018 12:06:08 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 33E3CE09FB; Wed, 3 Oct 2018 12:06:03 +0000 (UTC) Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id D615EE09C4 for ; Wed, 3 Oct 2018 12:06:02 +0000 (UTC) Received: from mail-io1-f53.google.com (mail-io1-f53.google.com [209.85.166.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: floppym) by smtp.gentoo.org (Postfix) with ESMTPSA id 9786A335C67 for ; Wed, 3 Oct 2018 12:06:00 +0000 (UTC) Received: by mail-io1-f53.google.com with SMTP id e2-v6so3088837ioh.5 for ; Wed, 03 Oct 2018 05:06:00 -0700 (PDT) X-Gm-Message-State: ABuFfoi2l6KpiWmH7+VdhVWEG8KAJ6Q+25WjPW6cWAi/cvEPVhyN782b IUQa0kdrtt9Pnaf0/EAj6p61ZBHXhFmBy3EqjHE= X-Google-Smtp-Source: ACcGV61oxzyyXZtDLeygb1TiB6N6UcqpNY1iEJeF9d++M6VhMUVO+bp5kMK/ZDI8wldf8N8Bu7xWO+EWqOBZDyB6NJ8= X-Received: by 2002:a6b:d817:: with SMTP id y23-v6mr751976iob.247.1538568358499; Wed, 03 Oct 2018 05:05:58 -0700 (PDT) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 References: <20181003021638.2475-1-floppym@gentoo.org> <1538552033.1042.0.camel@gentoo.org> <20181003102328.54aa5a30@red.yakaraplc.local> In-Reply-To: <20181003102328.54aa5a30@red.yakaraplc.local> From: Mike Gilbert Date: Wed, 3 Oct 2018 08:05:47 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [gentoo-dev] [PATCH] xdg-utils.eclass: don't call binaries from ROOT To: Gentoo Dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Archives-Salt: ca5c3994-ad9f-4e66-8988-90a5b0155c68 X-Archives-Hash: 150109b0d788cfa3af1a76089ab40a2d On Wed, Oct 3, 2018 at 5:23 AM James Le Cuirot wrote: > > On Wed, 03 Oct 2018 09:33:53 +0200 > Micha=C5=82 G=C3=B3rny wrote: > > > On Tue, 2018-10-02 at 22:16 -0400, Mike Gilbert wrote: > > > Avoid calling binaries that may have been compiled against different > > > libraries or even cross-compiled for an incomatible arch. > > > > > > Instead, always call the binaries installed in BROOT (/), if > > > available. > > > > Except BROOT doesn't have to be / (that's why we made it into > > a variable)! Also, wouldn't it be sufficient to use PATH lookup here > > and let the PM handle providing the correct root? > > To be clearer, EPREFIX refers to the target host, not the build host. > The build host may have a different prefix and that is the point of > BROOT. But as mgorny says, you should just rely on the PATH. We > primarily added BROOT for cases where using the PATH wasn't viable. > My mistake, I shouldn't have used the word "BROOT" to describe the root directory. Agreed, a PATH lookup should work here.