Re: [gentoo-dev] [PATCH] xdg-utils.eclass: don't call binaries from ROOT

[Mike Gilbert <floppym@gentoo.org>]

On Wed, Oct 3, 2018 at 5:23 AM James Le Cuirot <chewi@gentoo.org> wrote:
>
> On Wed, 03 Oct 2018 09:33:53 +0200
> Michał Górny <mgorny@gentoo.org> wrote:
>
> > On Tue, 2018-10-02 at 22:16 -0400, Mike Gilbert wrote:
> > > Avoid calling binaries that may have been compiled against different
> > > libraries or even cross-compiled for an incomatible arch.
> > >
> > > Instead, always call the binaries installed in BROOT (/), if
> > > available.
> >
> > Except BROOT doesn't have to be / (that's why we made it into
> > a variable)!  Also, wouldn't it be sufficient to use PATH lookup here
> > and let the PM handle providing the correct root?
>
> To be clearer, EPREFIX refers to the target host, not the build host.
> The build host may have a different prefix and that is the point of
> BROOT. But as mgorny says, you should just rely on the PATH. We
> primarily added BROOT for cases where using the PATH wasn't viable.
>

My mistake, I shouldn't have used the word "BROOT" to describe the
root directory.

Agreed, a PATH lookup should work here.