From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gentoo-dev+bounces-98694-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits))
	(No client certificate requested)
	by finch.gentoo.org (Postfix) with ESMTPS id B1E09158020
	for <garchives@archives.gentoo.org>; Tue,  6 Dec 2022 23:57:46 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id B9136E07E6;
	Tue,  6 Dec 2022 23:57:43 +0000 (UTC)
Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
	(No client certificate requested)
	by pigeon.gentoo.org (Postfix) with ESMTPS id 6FBCFE07D3
	for <gentoo-dev@lists.gentoo.org>; Tue,  6 Dec 2022 23:57:43 +0000 (UTC)
Received: by mail-yw1-f179.google.com with SMTP id 00721157ae682-3b56782b3f6so169250717b3.13
        for <gentoo-dev@lists.gentoo.org>; Tue, 06 Dec 2022 15:57:42 -0800 (PST)
X-Gm-Message-State: ANoB5pk9qq81wkT9wLQFUE4JrdOE48e3JYk5RTKg5gIdEduAIbM3NZoI
	JQnAZckEJ5O2vsa7XQcTp3s3uvAdIqPVexN041s=
X-Google-Smtp-Source: AA0mqf44oFg4kULQ7OAr1j9p42sBtqsVfqD5EyuZZ/uZHySiPT2/92p7yG/wVJKQkZrzQUa4oH4B5WvkvINPsdGI1Sc=
X-Received: by 2002:a0d:ea8e:0:b0:3b7:1b8a:6024 with SMTP id
 t136-20020a0dea8e000000b003b71b8a6024mr54689442ywe.421.1670371060617; Tue, 06
 Dec 2022 15:57:40 -0800 (PST)
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
MIME-Version: 1.0
References: <20221206222414.13633-1-chewi@gentoo.org> <20221206222414.13633-3-chewi@gentoo.org>
In-Reply-To: <20221206222414.13633-3-chewi@gentoo.org>
From: Mike Gilbert <floppym@gentoo.org>
Date: Tue, 6 Dec 2022 18:57:29 -0500
X-Gmail-Original-Message-ID: <CAJ0EP41pU1_yb4wtKWM9YO0XxfW-eEkz2R7ucTqWAXPHjUyZbQ@mail.gmail.com>
Message-ID: <CAJ0EP41pU1_yb4wtKWM9YO0XxfW-eEkz2R7ucTqWAXPHjUyZbQ@mail.gmail.com>
Subject: Re: [gentoo-dev] [PATCH 3/4] user-info.eclass: Fix for when building
 in a rooted prefix (EROOT)
To: gentoo-dev@lists.gentoo.org
Cc: James Le Cuirot <chewi@gentoo.org>
Content-Type: text/plain; charset="UTF-8"
X-Archives-Salt: dc8ebbcf-ed25-447d-9e88-d5a6a2ca473f
X-Archives-Hash: 0d3c81391344aa92641cb11ba69c4d61

On Tue, Dec 6, 2022 at 5:24 PM James Le Cuirot <chewi@gentoo.org> wrote:
>
> Users are largely irrelevant for prefix, but we still don't want the
> build to break.
>
> Signed-off-by: James Le Cuirot <chewi@gentoo.org>
> ---
>  eclass/user-info.eclass | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/eclass/user-info.eclass b/eclass/user-info.eclass
> index 5550e4f08eeb..1339e36634a8 100644
> --- a/eclass/user-info.eclass
> +++ b/eclass/user-info.eclass
> @@ -48,7 +48,7 @@ egetent() {
>                 fi
>
>                 # Handle different ROOT
> -               [[ -n ${ROOT} ]] && opts+=( -R "${ROOT}" )
> +               [[ -n ${ROOT} ]] && opts+=( -R "${EROOT}" )

Another case where the [[ -n ${ROOT} ]] should probably be changed to
[[ -n ${EROOT} ]] if you actually want this to be prefix-aware.