From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 0DB01158004 for ; Tue, 20 Feb 2024 05:59:15 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 531C0E2B11; Tue, 20 Feb 2024 05:59:12 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id D9F47E2B0D for ; Tue, 20 Feb 2024 05:59:11 +0000 (UTC) Received: by mail-yb1-f172.google.com with SMTP id 3f1490d57ef6-dcc80d6004bso5176645276.0 for ; Mon, 19 Feb 2024 21:59:11 -0800 (PST) X-Gm-Message-State: AOJu0YxNh5SExnuVqW1N4TWll07dVM6VWkUgo5kCQbs+76Pe6ahffOUu FMO9bkwX2+hFEHS0mut6hCTi/3bRI/+xqtb0q2WAuniBC8eWXf4ML3GVAjcArzCdU/msOcKnhsH th6+BzkJ6Gyxo5xGjvMiuOUnZbQg= X-Google-Smtp-Source: AGHT+IEjSUJ9ZxKORN8u3zmIuGSp9Y9osT2Q43CR4T2jDLGVLIbhXiLEju53/VlScwH72m7v1vFU0EKlMiHRr8BPzFg= X-Received: by 2002:a5b:a43:0:b0:dc2:32e6:18d9 with SMTP id z3-20020a5b0a43000000b00dc232e618d9mr12858253ybq.8.1708408749207; Mon, 19 Feb 2024 21:59:09 -0800 (PST) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 References: <20240220043235.3889132-1-eschwartz93@gmail.com> <20240220043235.3889132-2-eschwartz93@gmail.com> In-Reply-To: <20240220043235.3889132-2-eschwartz93@gmail.com> From: Mike Gilbert Date: Tue, 20 Feb 2024 00:58:58 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [gentoo-dev] [PATCH 1/3] meson.eclass: wire up LTO support directly into the meson options To: gentoo-dev@lists.gentoo.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Archives-Salt: b01dfeb1-ed80-4d61-96ef-1264d089d671 X-Archives-Hash: 7ee837857cd430b258028f1c39158e6a On Mon, Feb 19, 2024 at 11:26=E2=80=AFPM Eli Schwartz wrote: > > meson's builtin LTO support allows meson to introspect whether LTO is > enabled and do some fancy things, such as forcing LTO off for a single > target that is known to be special(ly bad) and not support LTO. Please make sure to test this change with a multilib-enabled ebuild with multiple ABIs enabled. I suspect the filter-lto call will cause differing results for the ABIs after the first. If that is the case, we may need to declare the relevant FLAGS variables with "local -x".