From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 0838B138334 for ; Sun, 30 Sep 2018 23:23:45 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 81125E089B; Sun, 30 Sep 2018 23:23:39 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 24EDAE0897 for ; Sun, 30 Sep 2018 23:23:38 +0000 (UTC) Received: from mail-io1-f54.google.com (mail-io1-f54.google.com [209.85.166.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: floppym) by smtp.gentoo.org (Postfix) with ESMTPSA id 9C9B8335C70 for ; Sun, 30 Sep 2018 23:23:36 +0000 (UTC) Received: by mail-io1-f54.google.com with SMTP id q4-v6so7970960iob.8 for ; Sun, 30 Sep 2018 16:23:36 -0700 (PDT) X-Gm-Message-State: ABuFfoitjyUHYHsDSjcI6dfInRZrrCNHzG+TO7+arLxsYKU3hGgAR4+8 JV6nd5DbEN95ukGPySuIAiH/SUpAn3MIxbcEpR8= X-Google-Smtp-Source: ACcGV61ypoLrPO6CyL0WD4EBUxNck2N/ScrK+zdimb/vm5ad+c5ccw4MFLr3HQWR/PNSQzhiOCzw0PuemeQTXy1yI24= X-Received: by 2002:a6b:d817:: with SMTP id y23-v6mr5743408iob.247.1538349814579; Sun, 30 Sep 2018 16:23:34 -0700 (PDT) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 References: <20180930225152.19011-1-mjo@gentoo.org> <20180930225152.19011-2-mjo@gentoo.org> In-Reply-To: <20180930225152.19011-2-mjo@gentoo.org> From: Mike Gilbert Date: Sun, 30 Sep 2018 19:23:23 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [gentoo-dev] [PATCH v2 1/1] profiles: unset USE=modules by default. To: Gentoo Dev Content-Type: text/plain; charset="UTF-8" X-Archives-Salt: 8a8c4b5f-f9e6-47c1-8039-3ad554ecebe1 X-Archives-Hash: 3da46975bd48105045444a78e3b87c08 On Sun, Sep 30, 2018 at 6:51 PM Michael Orlitzky wrote: > > The "modules" USE flag was originally enabled by default in the base > profile so that any ebuild inheriting linux-mod.eclass would have its > kernel modules built by default. However, the name of that USE flag is > now controlled by the MODULES_OPTIONAL_USE variable, set in the ebuild > itself. The best place for the USE flag default is therefore in IUSE > (in the ebuild), because only the ebuild knows the correct flag name. > > There are at least two packages, media-gfx/graphicsmagick and > net-im/mcabber, that assign a different meaning to the "modules" flag, > further suggesting that a global default is too blunt an approach. > > This commit drops the flag from base/make.defaults, and also from > default/linux/make.defaults where a redundant entry was present. > Thereafter, the override in features/hardened/make.defaults is > unnecessary, so it has been dropped as well. > > Closes: https://bugs.gentoo.org/635720 > Signed-off-by: Michael Orlitzky Looks good to me.