From: Mike Gilbert <floppym@gentoo.org>
To: Gentoo Dev <gentoo-dev@lists.gentoo.org>
Subject: Re: [gentoo-dev] [PATCH v2 1/1] profiles: unset USE=modules by default.
Date: Sun, 30 Sep 2018 19:23:23 -0400 [thread overview]
Message-ID: <CAJ0EP41geX3rowQxAuafHfcxrAnG_J5VuscFwjs2OTuakfTAHQ@mail.gmail.com> (raw)
In-Reply-To: <20180930225152.19011-2-mjo@gentoo.org>
On Sun, Sep 30, 2018 at 6:51 PM Michael Orlitzky <mjo@gentoo.org> wrote:
>
> The "modules" USE flag was originally enabled by default in the base
> profile so that any ebuild inheriting linux-mod.eclass would have its
> kernel modules built by default. However, the name of that USE flag is
> now controlled by the MODULES_OPTIONAL_USE variable, set in the ebuild
> itself. The best place for the USE flag default is therefore in IUSE
> (in the ebuild), because only the ebuild knows the correct flag name.
>
> There are at least two packages, media-gfx/graphicsmagick and
> net-im/mcabber, that assign a different meaning to the "modules" flag,
> further suggesting that a global default is too blunt an approach.
>
> This commit drops the flag from base/make.defaults, and also from
> default/linux/make.defaults where a redundant entry was present.
> Thereafter, the override in features/hardened/make.defaults is
> unnecessary, so it has been dropped as well.
>
> Closes: https://bugs.gentoo.org/635720
> Signed-off-by: Michael Orlitzky <mjo@gentoo.org>
Looks good to me.
next prev parent reply other threads:[~2018-09-30 23:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-30 22:51 [gentoo-dev] [PATCH v2 0/1] profiles: unset USE=modules by default Michael Orlitzky
2018-09-30 22:51 ` [gentoo-dev] [PATCH v2 1/1] " Michael Orlitzky
2018-09-30 23:23 ` Mike Gilbert [this message]
2018-10-07 21:56 ` [gentoo-dev] [PATCH v2 0/1] " Michael Orlitzky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJ0EP41geX3rowQxAuafHfcxrAnG_J5VuscFwjs2OTuakfTAHQ@mail.gmail.com \
--to=floppym@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox