[gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: app-emulation/runc/

[gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: app-emulation/runc/

[Robin H. Johnson]

On Mon, Dec 07, 2015 at 05:16:01AM +0000, Doug Goldstein wrote:
> commit:     37c1ec7ef31a51206421f03a2df489ec7d7ca244
> Author:     Doug Goldstein <cardoe <AT> gentoo <DOT> org>
> AuthorDate: Mon Dec  7 05:14:50 2015 +0000
> Commit:     Doug Goldstein <cardoe <AT> gentoo <DOT> org>
> CommitDate: Mon Dec  7 05:15:22 2015 +0000
> URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=37c1ec7e
> 
> app-emulation/runc: version bump
> 
> bump to latest upstream release.
> 
> Signed-off-by: Doug Goldstein <cardoe <AT> gentoo.org>
> 
>  app-emulation/runc/runc-0.0.5.ebuild | 52 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 52 insertions(+)
You did not update the Manifest or use repoman, and thus blocked the
rsync tree.

I fixed it now.

-- 
Robin Hugh Johnson
Gentoo Linux: Developer, Infrastructure Lead, Foundation Trustee
E-Mail     : robbat2@gentoo.org
GnuPG FP   : 11ACBA4F 4778E3F6 E4EDF38E B27B944E 34884E85

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: app-emulation/runc/

[Matt Turner]

On Mon, Dec 7, 2015 at 10:19 AM, Robin H. Johnson <robbat2@gentoo.org> wrote:
> On Mon, Dec 07, 2015 at 05:16:01AM +0000, Doug Goldstein wrote:
>> commit:     37c1ec7ef31a51206421f03a2df489ec7d7ca244
>> Author:     Doug Goldstein <cardoe <AT> gentoo <DOT> org>
>> AuthorDate: Mon Dec  7 05:14:50 2015 +0000
>> Commit:     Doug Goldstein <cardoe <AT> gentoo <DOT> org>
>> CommitDate: Mon Dec  7 05:15:22 2015 +0000
>> URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=37c1ec7e
>>
>> app-emulation/runc: version bump
>>
>> bump to latest upstream release.
>>
>> Signed-off-by: Doug Goldstein <cardoe <AT> gentoo.org>
>>
>>  app-emulation/runc/runc-0.0.5.ebuild | 52 ++++++++++++++++++++++++++++++++++++
>>  1 file changed, 52 insertions(+)
> You did not update the Manifest or use repoman, and thus blocked the
> rsync tree.
>
> I fixed it now.

This is happening with some frequency. Could we install a server-side
git hook that prevents pushes if an ebuild is added without a Manifest
change? It wouldn't have to verify anything more than that to catch
nearly all of these problems.

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: app-emulation/runc/

[Michael Orlitzky]

On 12/07/2015 01:26 PM, Matt Turner wrote:
>>
>> I fixed it now.
> 
> This is happening with some frequency. Could we install a server-side
> git hook that prevents pushes if an ebuild is added without a Manifest
> change? It wouldn't have to verify anything more than that to catch
> nearly all of these problems.
> 

The last time this happened I had the same idea and sat down to write
one. The pre-push hook would do something like,

  * Get a list of cat/pkg affected by the push

  * Compare that list to profiles/categories to see which ones are
    packages (and should thus have manifests)

  * Verify the integrity of the files in each affected package by using
    something like `repoman manifest-check`

I gave up when I realized that this final step requires network access.
The missing manifest updates are for the distfiles, not the ebuilds. But
you could probably still fake it. For example, if any ebuild files are
added/removed, you expect Manifest to change.

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: app-emulation/runc/

[Mike Gilbert]

On Mon, Dec 7, 2015 at 1:26 PM, Matt Turner <mattst88@gentoo.org> wrote:
> On Mon, Dec 7, 2015 at 10:19 AM, Robin H. Johnson <robbat2@gentoo.org> wrote:
>> On Mon, Dec 07, 2015 at 05:16:01AM +0000, Doug Goldstein wrote:
>>> commit:     37c1ec7ef31a51206421f03a2df489ec7d7ca244
>>> Author:     Doug Goldstein <cardoe <AT> gentoo <DOT> org>
>>> AuthorDate: Mon Dec  7 05:14:50 2015 +0000
>>> Commit:     Doug Goldstein <cardoe <AT> gentoo <DOT> org>
>>> CommitDate: Mon Dec  7 05:15:22 2015 +0000
>>> URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=37c1ec7e
>>>
>>> app-emulation/runc: version bump
>>>
>>> bump to latest upstream release.
>>>
>>> Signed-off-by: Doug Goldstein <cardoe <AT> gentoo.org>
>>>
>>>  app-emulation/runc/runc-0.0.5.ebuild | 52 ++++++++++++++++++++++++++++++++++++
>>>  1 file changed, 52 insertions(+)
>> You did not update the Manifest or use repoman, and thus blocked the
>> rsync tree.
>>
>> I fixed it now.
>
> This is happening with some frequency. Could we install a server-side
> git hook that prevents pushes if an ebuild is added without a Manifest
> change? It wouldn't have to verify anything more than that to catch
> nearly all of these problems.
>

That would not work for ebuilds which do not have any distfiles
associated with them.

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: app-emulation/runc/

[Matt Turner]

On Mon, Dec 7, 2015 at 10:58 AM, Mike Gilbert <floppym@gentoo.org> wrote:
> On Mon, Dec 7, 2015 at 1:26 PM, Matt Turner <mattst88@gentoo.org> wrote:
>> On Mon, Dec 7, 2015 at 10:19 AM, Robin H. Johnson <robbat2@gentoo.org> wrote:
>>> On Mon, Dec 07, 2015 at 05:16:01AM +0000, Doug Goldstein wrote:
>>>> commit:     37c1ec7ef31a51206421f03a2df489ec7d7ca244
>>>> Author:     Doug Goldstein <cardoe <AT> gentoo <DOT> org>
>>>> AuthorDate: Mon Dec  7 05:14:50 2015 +0000
>>>> Commit:     Doug Goldstein <cardoe <AT> gentoo <DOT> org>
>>>> CommitDate: Mon Dec  7 05:15:22 2015 +0000
>>>> URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=37c1ec7e
>>>>
>>>> app-emulation/runc: version bump
>>>>
>>>> bump to latest upstream release.
>>>>
>>>> Signed-off-by: Doug Goldstein <cardoe <AT> gentoo.org>
>>>>
>>>>  app-emulation/runc/runc-0.0.5.ebuild | 52 ++++++++++++++++++++++++++++++++++++
>>>>  1 file changed, 52 insertions(+)
>>> You did not update the Manifest or use repoman, and thus blocked the
>>> rsync tree.
>>>
>>> I fixed it now.
>>
>> This is happening with some frequency. Could we install a server-side
>> git hook that prevents pushes if an ebuild is added without a Manifest
>> change? It wouldn't have to verify anything more than that to catch
>> nearly all of these problems.
>>
>
> That would not work for ebuilds which do not have any distfiles
> associated with them.

Good point.

It *would* have to be somewhat more involved then...

[gentoo-dev] git update hook: detecting missing Manifest DIST entries

[Robin H. Johnson]

[-- Attachment #1: Type: text/plain, Size: 1566 bytes --]

On Mon, Dec 07, 2015 at 11:20:48AM -0800, Matt Turner wrote:
> >> This is happening with some frequency. Could we install a server-side
> >> git hook that prevents pushes if an ebuild is added without a Manifest
> >> change? It wouldn't have to verify anything more than that to catch
> >> nearly all of these problems.
> > That would not work for ebuilds which do not have any distfiles
> > associated with them.
> 
> Good point.
> 
> It *would* have to be somewhat more involved then...
I have given a lot of thought to it as well, because I've fixed it a
couple of times already or poked people to, and here's the best we can
do for the moment:

1. Script #1 (helper), that given an ebuild, spits out the filenames of the
   distfiles. 
   - Use an explicitly specified PORTDIR for eclasses.
   - Must NOT rely on the ebuild directory structure (i'd love to give
	 it the ebuild via stdin and tell it the path).
2. Script #2 (git update hook), check that filenames of distfiles are in
   the Manifest
3. Abort if #2 fails.

Potential problems:
It'll have to rely on a potentially less up to date set of eclasses.
So if there is an eclass change shortly followed by an ebuild change,
and the eclass change influences the distfiles, it MIGHT get it wrong
(in either direction).

I have existing code similar to script #2, so we just need script #1.

-- 
Robin Hugh Johnson
Gentoo Linux: Developer, Infrastructure Lead, Foundation Trustee
E-Mail     : robbat2@gentoo.org
GnuPG FP   : 11ACBA4F 4778E3F6 E4EDF38E B27B944E 34884E85

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 445 bytes --]

Re: [gentoo-dev] git update hook: detecting missing Manifest DIST entries

[Peter Stuge]

[-- Attachment #1: Type: text/plain, Size: 429 bytes --]

Robin H. Johnson wrote:
> 1. Script #1 (helper), that given an ebuild, spits out the filenames of the
>    distfiles. 
>    - Use an explicitly specified PORTDIR for eclasses.
>    - Must NOT rely on the ebuild directory structure (i'd love to give
> 	 it the ebuild via stdin and tell it the path).
..
> we just need script #1.

something FETCHCOMMAND=/bin/echo emerge --fetch-all-uri something something


//Peter

[-- Attachment #2: Type: application/pgp-signature, Size: 190 bytes --]