public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Mike Gilbert <floppym@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] RFC: Block ebuilds installing tests to ${D} by default
Date: Thu, 1 Feb 2024 16:52:58 -0500	[thread overview]
Message-ID: <CAJ0EP41eFja_yzmRFQ+NKdEEx8RVWPmgo97Q1=Q2vXdWC=FYMQ@mail.gmail.com> (raw)
In-Reply-To: <70c91f58-bf2f-48e9-8fa5-e67056114231@gmail.com>

On Thu, Feb 1, 2024 at 4:38 PM Eli Schwartz <eschwartz93@gmail.com> wrote:
>
> On 2/1/24 4:03 PM, Michał Górny wrote:
> > I suppose you are referring to dev-lang/python here.  Unfortunately,
> > removing tests from it is a non-trivial problem.  As I've mentioned to
> > you before, there are packages that actually import modules form the
> > test directory.
> >
> > Remember that Gentoo has a policy of following upstream, and this policy
> > is specifically targeted towards developers who expect Gentoo to
> > be a good baseline environment for developing packages.  By explicitly
> > diverging from upstream default install by default, we are effectively
> > creating an incompatible Python environment and requiring users to go
> > through extra steps to restore upstream compatibility.
>
>
> The "following upstream" argument is extremely weak.
>
> eschwartz ~/git/cpython $ ./configure --help| grep test
>   --disable-test-modules  don't build nor install test modules
>
>
> Clearly, upstream is giving you loud and clear permission to refrain
> from installing this. They even have a split in their Makefile variables:
> - LIBSUBDIRS: things that are always installed
> - TESTSUBDIRS: test files that you can disable

Ah, that's a relatively new configure option added in Python 3.10. It
didn't exist back in 2015 when I was looking into this.

https://docs.python.org/3/whatsnew/3.10.html#build-changes

Thanks for pointing it out.


  reply	other threads:[~2024-02-01 21:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-01  8:15 [gentoo-dev] RFC: Block ebuilds installing tests to ${D} by default Robin H. Johnson
2024-02-01 19:44 ` Mike Gilbert
2024-02-01 21:03 ` Michał Górny
2024-02-01 21:38   ` Eli Schwartz
2024-02-01 21:52     ` Mike Gilbert [this message]
2024-02-01 22:06       ` Eli Schwartz
2024-02-01 23:07 ` Andreas K. Huettel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJ0EP41eFja_yzmRFQ+NKdEEx8RVWPmgo97Q1=Q2vXdWC=FYMQ@mail.gmail.com' \
    --to=floppym@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox