From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 1D6D113933E for ; Thu, 15 Jul 2021 18:18:04 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id DE5C2E0BB8; Thu, 15 Jul 2021 18:17:59 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 87843E0B64 for ; Thu, 15 Jul 2021 18:17:59 +0000 (UTC) Received: by mail-yb1-f171.google.com with SMTP id p22so10563562yba.7 for ; Thu, 15 Jul 2021 11:17:58 -0700 (PDT) X-Gm-Message-State: AOAM530HkflhYfwq5c0H420FavmQImsw/8sBhtcXvirjtkZFBj627fAE OOY+D+j4yOSwY5Z3pFguXK/uBvC51oyN/0DcVSs= X-Google-Smtp-Source: ABdhPJzvHU80cTLezDy946YKH8S1GJcYVlxHKACcDf0fwvWZTQZmxcResNCzrqnedQZ4SV9J4yyr7PLQdGcYpXD6CSc= X-Received: by 2002:a25:5502:: with SMTP id j2mr7070037ybb.363.1626373075504; Thu, 15 Jul 2021 11:17:55 -0700 (PDT) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 References: <20210715111956.297120-1-flow@gentoo.org> In-Reply-To: From: Mike Gilbert Date: Thu, 15 Jul 2021 14:17:44 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [gentoo-dev] [PATCH] xdg.eclass: add EAPI 8 support To: Gentoo Dev Content-Type: text/plain; charset="UTF-8" X-Archives-Salt: b537862d-b867-49ff-a110-d59330505538 X-Archives-Hash: 7c802a88d2a4afd5d3c2a44521ad2e1f On Thu, Jul 15, 2021 at 9:29 AM Ionen Wolkens wrote: > > On Thu, Jul 15, 2021 at 03:23:04PM +0200, Ulrich Mueller wrote: > > >>>>> On Thu, 15 Jul 2021, Ionen Wolkens wrote: > > > > > Old DEPEND should be kept as-is not to risk breaking packages with odd > > > checks that need it present at build time. I'd rather no RDEPEND switch > > > either as it'll just complicate things with revbumps and tools don't > > > really need to be in RDEPEND given the above. > > > > Well, if the challenge was to pick the _worst_ match out of > > {,B,R,I}DEPEND then DEPEND would be the correct answer. :) > > Well, if really must improve it, I think BDEPEND is the better choice. > > Some packages use desktop-file-validate for their tests and the like. If ebuilds are using these programs directly (like for testing), they should really declare the dependency explicitly instead of relying on an implicit dependency in xdg.eclass. The eclass deps should be limited to functionality utilized by its exported phase functions. However, I realize older ebuilds were not written with that reasoning in mind, so I understand the "don't mess with older EAPIs" request from leio. Regarding BDEPEND/RDEPEND/IDEPEND, here's what we did with fcaps.eclass: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=789ec15b80a0ad2902d59be5bdb7c5fa6fcd0092 Quoting the commit message: This defines the native install-time libcap dependency as: - EAPI < 7: RDEPEND Only regular ROOT=/ builds can be expected to work. - EAPI = 7: RDEPEND + BDEPEND Also install the native setcap at built time, so cross- compiling will work, but not installing binpkgs in ROOTs. - EAPI > 7: IDEPEND Install native setcap at install-time; it works everywhere.