From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 541B3138334 for ; Wed, 3 Oct 2018 02:22:34 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 04E70E0960; Wed, 3 Oct 2018 02:22:29 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 97AB3E0958 for ; Wed, 3 Oct 2018 02:22:28 +0000 (UTC) Received: from mail-it1-f175.google.com (mail-it1-f175.google.com [209.85.166.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: floppym) by smtp.gentoo.org (Postfix) with ESMTPSA id E7C90335CFD for ; Wed, 3 Oct 2018 02:22:26 +0000 (UTC) Received: by mail-it1-f175.google.com with SMTP id p64-v6so6728565itp.0 for ; Tue, 02 Oct 2018 19:22:26 -0700 (PDT) X-Gm-Message-State: ABuFfoj1LpuTJDxuK3a/g6yOxoNC8mcQTGoz+w2nICXJhpCFLJ9nLttt vDyikUTSIorf/VGBAskFJxcsCPnsEst2IMzvpuo= X-Google-Smtp-Source: ACcGV60RJMieYTidlrsh5XGAbp6eGR4eDGUUVYXRKDKLF4quop+UyQP1QFddiJfPQGEU7TPPyaMnWJZHjSx8j1gmNRs= X-Received: by 2002:a02:9a1a:: with SMTP id b26-v6mr14578845jal.4.1538533344892; Tue, 02 Oct 2018 19:22:24 -0700 (PDT) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 References: <20180930225035.25434-1-floppym@gentoo.org> <20180930225035.25434-3-floppym@gentoo.org> <2e0b1447-d520-c4cc-61f6-7a1ad1761684@gentoo.org> <1538396835.9799.2.camel@gentoo.org> <20181001141724.58e98ebe@red.yakaraplc.local> <20181002021437.rf5ldh4wlciktd7n@proprietary-killer> In-Reply-To: <20181002021437.rf5ldh4wlciktd7n@proprietary-killer> From: Mike Gilbert Date: Tue, 2 Oct 2018 22:22:14 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [gentoo-dev] Re: [PATCH 3/5] xdg.eclass: move deps to RDEPEND To: Gentoo Dev Content-Type: text/plain; charset="UTF-8" X-Archives-Salt: d4044699-f5cb-4002-9146-dab3775a9a2f X-Archives-Hash: 107e1f01753b8edfac1becd17ec66a54 On Mon, Oct 1, 2018 at 10:14 PM Marty E. Plummer wrote: > > On Mon, Oct 01, 2018 at 10:08:03AM -0400, Mike Gilbert wrote: > > On Mon, Oct 1, 2018 at 9:17 AM James Le Cuirot wrote: > > > > > > On Mon, 1 Oct 2018 09:00:38 -0400 > > > Mike Gilbert wrote: > > > > > > > > The reason why it is in DEPEND though is that none of these tools > > > > > are required at runtime. They are needed at postinst and postrm > > > > > stages which afaik makes them DEPEND on EAPI previous to EAPI 7 and > > > > > BDEPEND in EAPI 7 if I'm not mistaken. > > > > > > > > This is incorrect; programs executed in pkg_postinst/pkg_postrm should > > > > be present in RDEPEND. Consider a binpkg installation, which would > > > > ignore DEPEND, but would still execute pkg_postinst. > > > > > > > > Another option: since xdg-utils.eclass functions will politely skip > > > > the updates if the tools are missing, we could just drop the > > > > dependency from xdg.eclass entirely and wait for the tools to get > > > > installed through some indirect means. > > > > > > Unfortunately there is no correct answer here as we didn't consider > > > this scenario when planning EAPI 7. We should have looked at Exherbo, > > > which does make this important distinction. There is a bug report open. > > > > > > https://bugs.gentoo.org/660306 > > > > > > What I will say is that we should not attempt to executing anything > > > from within ROOT or SYSROOT unless it known to be interpreted > > > (e.g. a shell script) and there is no feasible alternative. I add that > > > exclusion clause because I have been forced to do this with > > > python-config. > > > > That's a good point; both update-desktop-database and > > update-mime-database are compiled binaries, and should probably be > > executed from BROOT (/) instead. I'll revise my patchset. > > > Not to steal the show/etc, but I do have a patchset which does most of > this already across {gnome2,xdg}{,-utils}.eclass, though I'm as > conflicted as you guys are with regards to the DEPEND/PDEPEND/BDEPEND/RDPEND > for it as well. > https://archives.gentoo.org/gentoo-dev/message/e0167edbb7b48b03dc90bfbb250ae16d Thanks for pointing this out, I missed this patchset. Can you rebase on current master and add Signed-off-by? Or maybe start with a github pull request and we can work out the kinks there. Whichever you prefer. Note that I pushed my patches for xdg-utils.eclass already, and just sent another patch to drop EROOT from the binary paths. It would probably be best to drop EROOT from the gtk-update-icon-cache path as well.