From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gentoo-dev+bounces-98699-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits))
	(No client certificate requested)
	by finch.gentoo.org (Postfix) with ESMTPS id 9276E158003
	for <garchives@archives.gentoo.org>; Wed,  7 Dec 2022 16:53:16 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id F1693E07D1;
	Wed,  7 Dec 2022 16:53:12 +0000 (UTC)
Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
	(No client certificate requested)
	by pigeon.gentoo.org (Postfix) with ESMTPS id 79D9BE07B3
	for <gentoo-dev@lists.gentoo.org>; Wed,  7 Dec 2022 16:53:12 +0000 (UTC)
Received: by mail-yb1-f181.google.com with SMTP id 189so23437948ybe.8
        for <gentoo-dev@lists.gentoo.org>; Wed, 07 Dec 2022 08:53:11 -0800 (PST)
X-Gm-Message-State: ANoB5pkr38KySq4q11mXwUKvmibzv26tObvegBhmQOeMaadHeKeM9fuf
	kUNh45gasas4XDMnVwOEzbPcT82+1HvZQfYFB+Y=
X-Google-Smtp-Source: AA0mqf7fDY4jBfr0aTmSFNEuRlW02IN2BS0SBxbxQnxMdnXGcXlDwPqLTgeKkIVfQu/NSlsHtpHJ5AGvM5G+UxhIMUE=
X-Received: by 2002:a25:c442:0:b0:703:a37:73da with SMTP id
 u63-20020a25c442000000b007030a3773damr8481593ybf.429.1670431989516; Wed, 07
 Dec 2022 08:53:09 -0800 (PST)
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
MIME-Version: 1.0
References: <20221206222414.13633-1-chewi@gentoo.org> <CAJ0EP42CR_O8OK--PtpRjef+aO9ck6RWm5_R4Ab=dAm=pcoJfw@mail.gmail.com>
 <e39520806d6d7917ff03c06680117a7c2ddd77bd.camel@gentoo.org>
In-Reply-To: <e39520806d6d7917ff03c06680117a7c2ddd77bd.camel@gentoo.org>
From: Mike Gilbert <floppym@gentoo.org>
Date: Wed, 7 Dec 2022 11:52:58 -0500
X-Gmail-Original-Message-ID: <CAJ0EP40w2MUnd7covLQuTdMdmFCqujiBhy8GedhdbpCkWhryrQ@mail.gmail.com>
Message-ID: <CAJ0EP40w2MUnd7covLQuTdMdmFCqujiBhy8GedhdbpCkWhryrQ@mail.gmail.com>
Subject: Re: [gentoo-dev] [PATCH 1/4] acct-group.eclass: Fix for when building
 in a rooted prefix (EROOT)
To: gentoo-dev@lists.gentoo.org
Content-Type: text/plain; charset="UTF-8"
X-Archives-Salt: 9b80444e-ac61-4c6a-803d-ea9163563726
X-Archives-Hash: 0d4fea993b572b70d975d05ecc74fd1b

On Wed, Dec 7, 2022 at 4:24 AM James Le Cuirot <chewi@gentoo.org> wrote:
> The new eclasses also skip the operation if you are root. As that bug report
> says, running a prefixed system as root is probably unsupported. I was doing
> this as root into a ROOTed prefix though, which is slightly different. Should
> we also skip the operation if EPREFIX non-empty? I'll think about it.

I would be in favor of skipping adding users/groups if EPREFIX is
non-empty, at least as a temporary solution.

If someone presents a use case where adding users to
${EROOT}/etc/passwd makes sense, we can revisit it then.