From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gentoo-dev+bounces-96048-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits))
	(No client certificate requested)
	by finch.gentoo.org (Postfix) with ESMTPS id 42BB3158086
	for <garchives@archives.gentoo.org>; Thu, 25 Nov 2021 17:14:36 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id 9F88C2BC03F;
	Thu, 25 Nov 2021 17:14:31 +0000 (UTC)
Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits))
	(No client certificate requested)
	by pigeon.gentoo.org (Postfix) with ESMTPS id 58A732BC00A
	for <gentoo-dev@lists.gentoo.org>; Thu, 25 Nov 2021 17:14:31 +0000 (UTC)
Received: by mail-yb1-f178.google.com with SMTP id f9so13455519ybq.10
        for <gentoo-dev@lists.gentoo.org>; Thu, 25 Nov 2021 09:14:30 -0800 (PST)
X-Gm-Message-State: AOAM531u+/ETCB9Dj41WEhD7G1ygXj69e4kZV+8LBEmMBPOM11ahzpCR
	S1Xzd8m0sxtZtnJTFuWXmUpzoYG4/aYBDf+LMbo=
X-Google-Smtp-Source: ABdhPJyS4ppouqW6E3COt0mOWBDgDuJ7VVgZN1OgG3DZewJeCdVEwf4aeOw1aOdNDvkh1qv0rxLn2V7r1cCOcQRuPm4=
X-Received: by 2002:a25:44:: with SMTP id 65mr7701545yba.480.1637860466887;
 Thu, 25 Nov 2021 09:14:26 -0800 (PST)
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
MIME-Version: 1.0
References: <20211125032133.6916-1-whissi@gentoo.org> <CAJ0EP41C8OHMw9AxgCPQ4M6O3-aGYtDfy3J5ckTrwY7Ov0da3Q@mail.gmail.com>
 <505f8321-d399-18a2-3dd7-f64fd7541519@gentoo.org> <CAJ0EP42Ar9+Rvbaj5AdH0WQvaNfGRzQtdJKfq=tBzSX=iX9G=g@mail.gmail.com>
 <01fabedca3374352a55f3b74c615edd8e4f4d3ff.camel@gentoo.org>
 <ee7d10f7-9db1-ccdf-6273-270b7168862a@gentoo.org> <5b1ca0441be261427fda3c3b1c623e86775e692c.camel@gentoo.org>
 <9701d549-7a9b-a056-b8d9-954b1ee8687a@gentoo.org>
In-Reply-To: <9701d549-7a9b-a056-b8d9-954b1ee8687a@gentoo.org>
From: Mike Gilbert <floppym@gentoo.org>
Date: Thu, 25 Nov 2021 12:14:16 -0500
X-Gmail-Original-Message-ID: <CAJ0EP40kZsSOU-zANr0NWOVsYL8Qzn472_WspdTakVzkD+_1QA@mail.gmail.com>
Message-ID: <CAJ0EP40kZsSOU-zANr0NWOVsYL8Qzn472_WspdTakVzkD+_1QA@mail.gmail.com>
Subject: Re: [gentoo-dev] [PATCH] 2021-11-23-mariadb-database-restore-maybe-required:
 add item
To: Gentoo Dev <gentoo-dev@lists.gentoo.org>
Content-Type: text/plain; charset="UTF-8"
X-Archives-Salt: 0c431214-78bf-452c-8bf9-7d60bc4796c2
X-Archives-Hash: ee53b66a13fd2a9bc514dfd6a6bedcea

On Thu, Nov 25, 2021 at 12:01 PM Piotr Karbowski <slashbeast@gentoo.org> wrote:
>
> > https://github.com/gentoo/gentoo/blob/master/sys-libs/glibc/glibc-2.34-r2.ebuild#L643
>
> Would you see something like this on more ebuilds, postgres, mysql,
> elasticsearch, or have proper FEATURE flag for it instead?
>
> It's all cool and giggles until you realize that even such random
> variable is not even prefixed with PORTAGE_ or anything, meaning it
> could be taken out of shell and meant for entirely different thing.

Another problem with such magic variables is that they are ineffective
when installing binpkgs. During pkg_preinst, portage will restore the
environment variables that were present when the package was built,
and ignore anything you have set in the environment since then.