From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 6213015800A for ; Tue, 18 Jul 2023 17:31:42 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id B4ED3E0817; Tue, 18 Jul 2023 17:31:38 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 73E9AE0801 for ; Tue, 18 Jul 2023 17:31:38 +0000 (UTC) Received: by mail-oo1-f41.google.com with SMTP id 006d021491bc7-5634d8d1db0so3688278eaf.0 for ; Tue, 18 Jul 2023 10:31:37 -0700 (PDT) X-Gm-Message-State: ABy/qLbmmOsVc/hOmciEGWHKG1TPuZjDWiFcjscxxZ7f5/WJ+b1cufLu 4z/xHu99Nd/ligIBE+KRTq7gZrRLBxLirPiZBAM= X-Google-Smtp-Source: APBJJlG8imYAhuEJOqoJc3sU+j3BNMj8ELCyAEytUGHUHQ22Ux8AfHeGTOkfAT0FD9fdhYgEmWEFriwxnmm0sA8CGxA= X-Received: by 2002:a05:6358:c1d:b0:135:4dcf:9a2a with SMTP id f29-20020a0563580c1d00b001354dcf9a2amr13174611rwj.7.1689701495869; Tue, 18 Jul 2023 10:31:35 -0700 (PDT) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 References: <20230717152123.1467096-1-mattst88@gentoo.org> In-Reply-To: <20230717152123.1467096-1-mattst88@gentoo.org> From: Mike Gilbert Date: Tue, 18 Jul 2023 13:31:24 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [gentoo-dev] [PATCH 1/2] ninja-utils.eclass: Add NINJA_VERBOSE To: gentoo-dev@lists.gentoo.org Cc: mgorny@gentoo.org, base-system@gentoo.org, kde@gentoo.org, Matt Turner Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Archives-Salt: 64ac84c5-eba9-4adf-9a30-6a91eedbbebd X-Archives-Hash: 4ae093f830ab8a88d16e41e10a3f22da On Mon, Jul 17, 2023 at 11:21=E2=80=AFAM Matt Turner = wrote: > > ninja operates in one of three modes: > - verbose (with -v): prints build commands > - quiet (with --quiet): prints nothing > - normal: prints [XX/YY]-style build status updates > > samurai works the same way, except it does not have a quiet mode. > > Thus we can't simply override ninja-utils' hard-coded flag from callers > of eninja. Seems ok to me.