From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1S0H7o-0002OP-9N for garchives@archives.gentoo.org; Wed, 22 Feb 2012 18:41:12 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 2EA6AE1461; Wed, 22 Feb 2012 18:40:53 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id B86C8E1433 for ; Wed, 22 Feb 2012 18:40:04 +0000 (UTC) Received: from mail-pz0-f53.google.com (mail-pz0-f53.google.com [209.85.210.53]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: floppym) by smtp.gentoo.org (Postfix) with ESMTPSA id B3EA01B402E for ; Wed, 22 Feb 2012 18:40:02 +0000 (UTC) Received: by dady25 with SMTP id y25so370336dad.40 for ; Wed, 22 Feb 2012 10:40:01 -0800 (PST) Received-SPF: pass (google.com: domain of floppym@gentoo.org designates 10.68.223.167 as permitted sender) client-ip=10.68.223.167; Authentication-Results: mr.google.com; spf=pass (google.com: domain of floppym@gentoo.org designates 10.68.223.167 as permitted sender) smtp.mail=floppym@gentoo.org Received: from mr.google.com ([10.68.223.167]) by 10.68.223.167 with SMTP id qv7mr42892057pbc.139.1329936001064 (num_hops = 1); Wed, 22 Feb 2012 10:40:01 -0800 (PST) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Received: by 10.68.223.167 with SMTP id qv7mr35462986pbc.139.1329936001049; Wed, 22 Feb 2012 10:40:01 -0800 (PST) Received: by 10.68.46.135 with HTTP; Wed, 22 Feb 2012 10:40:00 -0800 (PST) In-Reply-To: References: <4F40D7C3.1070906@gentoo.org> <1329862452.25132.0.camel@keitaro> Date: Wed, 22 Feb 2012 13:40:00 -0500 Message-ID: Subject: Re: [gentoo-dev] RFC patch for subversion.eclass (bug 401737) From: Mike Gilbert To: gentoo-dev@lists.gentoo.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Archives-Salt: 75f0b923-1a0d-4ce2-8df5-2db68a364568 X-Archives-Hash: fcff1736319ad5bfa2a3453eec43c47e On Wed, Feb 22, 2012 at 12:33 PM, Matthew Summers wrote: > On Tue, Feb 21, 2012 at 4:14 PM, Gilles Dartiguelongue w= rote: >> Le dimanche 19 f=C3=A9vrier 2012 =C3=A0 12:06 +0100, Justin a =C3=A9crit= : >>> Hi, >>> >>> any objections against following patch for subversion.eclass? >>> Fixes bug 401737. Basically respects ESVN_{USER,PASSWORD} during >>> reemerge of a package. >>> >>> >>> --- subversion.eclass 2012-02-07 11:56:27.000000000 +0200 >>> +++ subversion.eclass 2012-02-07 11:59:38.000000000 +0200 >>> @@ -469,7 +469,9 @@ >>> =C2=A0 =C2=A0 =C2=A0 local target=3D"${1}" >>> =C2=A0 =C2=A0 =C2=A0 local key=3D"${2}" >>> >>> - =C2=A0 =C2=A0 env LC_ALL=3DC svn info "${target}" | grep -i "^${key}"= | cut -d" " -f2- >>> + =C2=A0 =C2=A0 env LC_ALL=3DC svn info \ >>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ${options} --username "${ES= VN_USER}" --password "${ESVN_PASSWORD}" \ >>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "${target}" | grep -i "^${k= ey}" | cut -d" " -f2- >>> =C2=A0} >>> >>> =C2=A0## -- subversion__get_repository_uri() >>> --------------------------------------- # >> >> I'm not an expert of the subversion eclass, but the diff looks good. >> >> -- >> Gilles Dartiguelongue >> Gentoo > > Why would you want a password in an ebuild? The var ESVN_PASSWORD > seems like trouble to me. I think the intended usage is by the user on the command line, or in a package.env file.