Re: [gentoo-dev] RFC patch for subversion.eclass (bug 401737)

[Mike Gilbert <floppym@gentoo.org>]

On Wed, Feb 22, 2012 at 12:33 PM, Matthew Summers
<quantumsummers@gentoo.org> wrote:
> On Tue, Feb 21, 2012 at 4:14 PM, Gilles Dartiguelongue <eva@gentoo.org> wrote:
>> Le dimanche 19 février 2012 à 12:06 +0100, Justin a écrit :
>>> Hi,
>>>
>>> any objections against following patch for subversion.eclass?
>>> Fixes bug 401737. Basically respects ESVN_{USER,PASSWORD} during
>>> reemerge of a package.
>>>
>>>
>>> --- subversion.eclass 2012-02-07 11:56:27.000000000 +0200
>>> +++ subversion.eclass 2012-02-07 11:59:38.000000000 +0200
>>> @@ -469,7 +469,9 @@
>>>       local target="${1}"
>>>       local key="${2}"
>>>
>>> -     env LC_ALL=C svn info "${target}" | grep -i "^${key}" | cut -d" " -f2-
>>> +     env LC_ALL=C svn info \
>>> +             ${options} --username "${ESVN_USER}" --password "${ESVN_PASSWORD}" \
>>> +             "${target}" | grep -i "^${key}" | cut -d" " -f2-
>>>  }
>>>
>>>  ## -- subversion__get_repository_uri()
>>> --------------------------------------- #
>>
>> I'm not an expert of the subversion eclass, but the diff looks good.
>>
>> --
>> Gilles Dartiguelongue <eva@gentoo.org>
>> Gentoo
>
> Why would you want a password in an ebuild? The var ESVN_PASSWORD
> seems like trouble to me.

I think the intended usage is by the user on the command line, or in a
package.env file.