public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Mike Gilbert <floppym@gentoo.org>
To: Sam James <sam@gentoo.org>
Cc: gentoo-dev@lists.gentoo.org, base-system@gentoo.org,
	eschwartz@gentoo.org
Subject: [gentoo-dev] Re: [PATCH 2/2] meson.eclass: build test targets first in meson_src_test
Date: Sun, 6 Apr 2025 15:42:17 -0400	[thread overview]
Message-ID: <CAJ0EP40BWZp-if8=4M8jdPhK1zbeo6dwwfCOH+hBKXEYViUaiQ@mail.gmail.com> (raw)
In-Reply-To: <6cef3ecbaa1909ebe9d848fa0d6ba3e9891ca7bd.1743917689.git.sam@gentoo.org>

On Sun, Apr 6, 2025 at 1:34 AM Sam James <sam@gentoo.org> wrote:
>
> Newer versions of meson [0] don't build all test targets upfront (which
> makes this more noticeable, still was a thing before w/ custom handling)
> so, in the common case, test binaries are built by the `meson test` call.
>
> That means their compile/link lines aren't emitted (even with `meson test --verbose`)
> and they're also built without respecting $(makeopts_jobs) as `meson test
> --num-processes` only affects test execution parallelism.
>
> Preempt that by calling `eninja meson-test-prereq` first which solves both
> problems. We can safely do this unconditionally as this target was added
> in meson-0.63.0 and we depend on >=meson-1.2.3 in the eclass.

I think this change will break sys-apps/systemd-utils, which builds
only a subset of the available test binaries.

It's probably fine in most cases, I just wanted to point it out.


      reply	other threads:[~2025-04-06 19:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-06  5:34 [gentoo-dev] [PATCH 1/2] meson.eclass: use edo Sam James
2025-04-06  5:34 ` [gentoo-dev] [PATCH 2/2] meson.eclass: build test targets first in meson_src_test Sam James
2025-04-06 19:42   ` Mike Gilbert [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJ0EP40BWZp-if8=4M8jdPhK1zbeo6dwwfCOH+hBKXEYViUaiQ@mail.gmail.com' \
    --to=floppym@gentoo.org \
    --cc=base-system@gentoo.org \
    --cc=eschwartz@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    --cc=sam@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox