From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 73B3C1581D3 for ; Wed, 15 May 2024 16:02:27 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 079DCE2A77; Wed, 15 May 2024 16:02:24 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id AD837E2A3D for ; Wed, 15 May 2024 16:02:23 +0000 (UTC) Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-574bf7ab218so2169872a12.1 for ; Wed, 15 May 2024 09:02:22 -0700 (PDT) X-Gm-Message-State: AOJu0Yzu92ipM7eX5pxTNjncR1WNkFCsjFDuPEGzWORM/OKVtvvJsrX1 9Zz7oEh6//poMCA9HAZTGDUWSOU7zFoWGMMABDzujIA5y2Fwz8LYfP+gsyrtKd6/xPrhWshiot7 BBU0dIbm+Bg0fTFLEJdczd3Zy0Mg= X-Google-Smtp-Source: AGHT+IEzphafeo5z1VRmBnjGLK/txHRuC6QoCT4GZzKivb7soFML4ETajZsY8OPHrwWIkJtnNbRSc35cVZuO1WuJVgU= X-Received: by 2002:a50:d653:0:b0:572:7d75:a715 with SMTP id 4fb4d7f45d1cf-5734d6b4120mr10719962a12.28.1715788940187; Wed, 15 May 2024 09:02:20 -0700 (PDT) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 References: <20240514115924.29167-1-andrewammerlaan@gentoo.org> <20240514115924.29167-6-andrewammerlaan@gentoo.org> In-Reply-To: <20240514115924.29167-6-andrewammerlaan@gentoo.org> From: Mike Gilbert Date: Wed, 15 May 2024 12:02:07 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [gentoo-dev] [PATCH 6/7] linux-info.eclass: respect eselect kernel setting in binpkgs To: gentoo-dev@lists.gentoo.org Cc: Andrew Ammerlaan Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Archives-Salt: 37e2b52f-dd5f-4541-beb4-3e51beb7166f X-Archives-Hash: 343348e55a8eb768bd9229852c05c7f6 On Tue, May 14, 2024 at 7:59=E2=80=AFAM Andrew Ammerlaan wrote: > Commit f51cd5b64c14ddfb83488a12d538c66a4a309376 resets kernel environment > variables when binpkgs are merged, this makes sense since we care about t= he > system that the binpkg will be installed on, not the system the binpkg wa= s > built on. This introduced Bug 931213 as a side-effect, which will be fixe= d > in a separate commit to linux-mod-r1.eclass. In preparation of that, we d= ocument > and rename the LINUX_INFO_BINARY_RESET to SKIP_KERNEL_BINPKG_ENV_RESET. > > However, commit f51cd5b64c14ddfb83488a12d538c66a4a309376 also makes binpk= gs > always use the running kernel version. This behaviour is surprising and > confusing. In principle the 'eselect kernel' setting should still be resp= ected > when binpkgs are used. Seems reasonable to me as the author of f51cd5b64c14ddfb83488a12d538c66a4a309376.